I've published all the externals I wrote for VS Code (and other libraries) <https://github.com/lpped...

# javascript

[Edoardo Luppi]

I've published all the externals I wrote for VS Code (and other libraries)
https://github.com/lppedd/kotlin-externals

They're not pushed to Maven Central yet, as I want to first use them internally and see how they work.

[turansky]

0. Good work!
0.1. We need 1 mega-repository 🙂

Fast review results:
1. Vararg processing is invalid
a. ...args: any[] -> vararg args Any (without Array)
2. Array -> ReadonlyArray expected
3. Union can be/must be replaced with more elegant solution
a. We have some drafts for wrappers
4. @JsTrue /`@JsFalse` problem partially solved in Seskar
a. Check required if you have additional cases
cc @Sergei Grishchenko

[Edoardo Luppi]

Thanks! Will fix them!

We need 1 mega-repository

I couldn't push them to kotlin-wrappers as they're not really auto-generated (as you can see from the readme), but hopefully at some point the generation process will be able to cover 99% of the cases without having to write a lot of additional code.

[Edoardo Luppi]

Btw, where did you find the vararg with Array?

[Edoardo Luppi]

The Union typealias is just to let me understand it's a union, so that when I go back to fix them, if ever Kotlin will support denotable unions, it will be easier

[turansky]

Union in TS != can't be strict in Kotlin

[turansky]

We have pills with Kotlin magic

[Edoardo Luppi]

Solved the Array stuff. Now I need to wait for Seskar and then I can try to build a VS Code extensions with them

[Edoardo Luppi]

The most problematic part will be writing tests with Mocha.

Usually Mocha test suites are top level in the file.
However Kotlin doesn't have a top level concept for function calls.

[turansky]

Do you use Seskar in common code?

[Edoardo Luppi]

No everything is under jsMain

[Edoardo Luppi]

Although if https://youtrack.jetbrains.com/issue/KT-56618 gets done, I'll move externals under commonMain

[turansky]

JS externals in common main?

[Edoardo Luppi]

Ahh no sorry, that is for @JsExport, wrong issue

[Edoardo Luppi]

But anyway, the problem with Seskar is it's using the "old" way of attaching JS dependencies.
If I recall correctly it was changed 1.3 or 1.4

[Edoardo Luppi]

JS externals in common main?

Now that I've read that issue again, it's exactly what is being proposed. At least for interfaces

[turansky]

Why do you need JS interfaces in common?

[Edoardo Luppi]

Better interop with JS consumers

[Edoardo Luppi]

It was easy after understanding the configuration order part
https://github.com/lppedd/kotlin-externals/commit/f80f19b66027eeb0a003328267d047e90a194d43

[Edoardo Luppi]

Works fine now, thanks!