https://kotlinlang.org logo
#koin-contributors
Title
# koin-contributors
p

Pedro Francisco de Sousa Neto

02/26/2024, 1:01 PM
I couldn't start this task, but @Gustavo Barbosa Barreto will do it! ;)
g

Gustavo Barbosa Barreto

02/26/2024, 1:03 PM
Yep, I'm checking it...
🚀 1
brazil 1
p

Pedro Francisco de Sousa Neto

02/29/2024, 12:32 AM
Here is the issue related, @Gustavo Barbosa Barreto https://github.com/InsertKoinIO/koin/issues/1750
g

Gustavo Barbosa Barreto

02/29/2024, 11:32 AM
Thanks @Pedro Francisco de Sousa Neto, I'm creating the tests... I think that soon I'll be able to open a PR.
@arnaud.giuliani and @Pedro Francisco de Sousa Neto, I've created a draft PR including tests to cover some scenarios about the VM problem. Could you check if it's enough? Pull Request: https://github.com/InsertKoinIO/koin/pull/1800
a

arnaud.giuliani

03/01/2024, 8:16 AM
yeah, changed to 3.5.4 branch
gratitude thank you 1
g

Gustavo Barbosa Barreto

03/01/2024, 12:21 PM
Thanks! What do you prefer, create more tests at this PR to increase the coverage or merge this PR and create another?