Which do you prefer between: ```isRunning = result...

# codereview

[CLOVIS]

Which do you prefer between:

isRunning = result != null && result.isActive

isRunning = !(result == null || !result.isActive)

[ephemient]

isRunning = result?.isActive == true

[Joffrey]

I personally find the nullable boolean checks with == true slightly less readable than the clear null check + regular boolean check. In general I don't find that saving a few characters is worth this slight readability drop.

[Joffrey]

Most of the time I'd rather refactor so there is no null in the first place anyway 😄

[ephemient]

YMMV? I find the ?. version easier to read than the more complex boolean expression. there's three states: null, false, and true, and you can clearly see which ones pass

[Joffrey]

Fair enough. I guess it depends on preference or past experience. I usually find that the 3 states are not in the same dimension: there is a missing info state on one side, and the true/false states on the other. So it feels wrong to me to compare them in a single expression. I prefer to see that there was a conscious decision to handle the "missing value" state here too.

[ephemient]

https://kotlinlang.org/docs/coding-conventions.html#nullable-boolean-values-in-conditions indicates a preference towards using == true or == false with `null`able Boolean too

[Joffrey]

It does. I just disagree with it 😄

[Shaun Burch]

isRunning = result?.isActive ?: false

I prefer to nip nullability asap, but if unable to prior – like stating the result when null with the king elvis.

[Joffrey]

Yep I find that version clearer