A modern programming language that makes developers happier.

kotlinlang

A proposed of flatten modules function PR : <https://github.com/InsertKoinIO/koin/pull/1801>

`flatten` is very well defined recursively, and adding extra allocations explicitly clutters the code and makes it less readable than the recursive version

I think maybe fixing the recursive version is possible instead of replacing it by an iterative one

That is very nice, thank you for the heads-up here Arnaudi! I did a review in the CL. :slightly_smiling_face:

About using a recursive `tailrec` or a iterative approach, for such a simple self-contianed and “by the book” BFS, my opinion is that these implementation details are irrelevant; I would avoid entering the realm of <https://en.wikipedia.org/wiki/Law_of_triviality|bike-shedding> here.

Also, the fact we are basically rolling back to the original `flatten` implementation due to performance issues is a strong statement we don’t need to over complicate.

Of course, we can always do improvements and change to another approach if the need appears.

Ok, let's keep the classic flatten by hand then :slightly_smiling_face: