Hey everyone, I've been digging into my app's perf...

# compose

[Sergey Y.]

Hey everyone, I've been digging into my app's performance, and I found that some of my composables are never skippable. So, I ran Compose compiler reports to see the actual stability of classes and functions, and I was surprised by some weirdness.

Any insights or help would be greatly appreciated!

Details in the thread 🧵

[Sergey Y.]

In my app's state class, one particular but important property was inferred as unstable, regardless of the compiler config and explicit class annotations. However, other similar properties were recognized as stable. I'm wondering if there's something wrong with the stableRenderableGroups: ImmutableList<StableRenderableGroup> property.

`compose-bom = "2024.02.01`"

[Sergey Y.]

StableRenderableGroup and the subclasses are stable:

[Sergey Y.]

Hm, adding the StableRenderableGroup class to the Compose compiler configuration file marked this property as stable, which is weird.
But why it ignored the annotations?

Now the composable function is skippable, but if anyone knows the reason for such behavior, I would like to know to avoid or avert such behavior in the future. 🙂

[Ben Trengrove [G]]

I think you have hit the exact bug I am working on right now. Basically, if we hit nested generic classes when analysing stability we declare them as unstable

[Ian Lake]

That would be https://android-review.googlesource.com/c/platform/frameworks/support/+/2988009 for those without Google Corp access 🙂

[Ben Trengrove [G]]

Doh 😆

[Ian Lake]

And the public bug to star: https://issuetracker.google.com/issues/327643787

[Sergey Y.]

Oh nice, this one I can easily track, and I'll be eagerly awaiting the fix.

[Ben Trengrove [G]]

It will be in the compiler release once merged