I'm working on an overhaul of the websocket architecture. Current planned improvements:
• Select binary/text mode in WsMessage: no longer determined by body type
• Symmetric WsHandler: injected into client to represent real client or fake implementation
• Reject websocket connections
Any other pain points?
d
dave
03/26/2024, 3:46 PM
The main thing I want to make sure of is to retain the offline testability. I (hopefully) think that the intro of the symmetric hander will actually improve this.
And when it's done, we can roll it out of the SSE as well.
If you want I can create a dedicated rewrite branch so it all doesn't have to be done at once. 🙂
a
Andrew O'Hara
03/26/2024, 4:37 PM
Sure, go ahead and make it. The symmetry does actually make testing so much easier. Rewriting the existing tests has been a breeze.