Hi folks, I have added detekt-formatting dependenc...

# detekt

[Abhimanyu]

Hi folks,
I have added detekt-formatting dependency as mentioned here.
https://detekt.dev/docs/rules/formatting#ifelsebracing

But, executing ./gradlew detekt does not show any formatting issues.

Repo id required - https://github.com/Abhimanyu14/finance-manager

[Abhimanyu]

I also came across this discussion,
https://github.com/detekt/detekt/discussions/5997

Does detekt support all the klint rules now?

[Nicholas Doglio]

I didn't see your detekt config file but it needs to include the formatting rules

[Nicholas Doglio]

Does detekt support all the klint rules now?

I think they're current with ktlint 1.1 but haven't updated to 1.2 yet. I'm not sure what the long term plans are though

[Nicholas Doglio]

Oops found it https://github.com/Abhimanyu14/finance-manager/blob/main/codebase/android/config/detekt/detekt.yml

[Nicholas Doglio]

Yeah you need to add the formatting rules here

[Abhimanyu]

Hi @Nicholas Doglio,
I noticed that my issue was that even though I add rules to the config, the config file rules are ignored.
(Not just formatting rules, all the rules in the file is ignored and default rules are used)

(I am testing locally by adding new rules, editing existing rules, etc).

I am executing detekt in the terminal.

./gradlew detektDebug

[Abhimanyu]

I have added this in the project build.gradle.

detekt {
    toolVersion = "1.23.6"
    config.setFrom(file("config/detekt/detekt.yml"))
    buildUponDefaultConfig = true
}

[Nicholas Doglio]

Can you push your changes? everything you’ve shared looks correct I’m not sure why it isn’t working for you

[Abhimanyu]

I have pushed my changes now.

[Nicholas Doglio]

I don’t see anything pushed recently

[Abhimanyu]

Pushed again now.
I might have missed to push something earlier.

BTW, detekt was added in my project long back, but I never actually used it.
Getting around to it only now.

[Abhimanyu]

Found the issue.
I was thinking applying the plugin only on the project build.gradle should work.

Adding the plugin to all the modules works now.

[Abhimanyu]

Still, facing issues with formatting rules.
I will share more on that once I fixed the detekt issues with current setup for all modules.