<@U01SP2GJYAU> I'm trying to make a base repositor...

# komapper

[dave08]

@Toshihiro Nakamura I'm trying to make a base repository without exposing Komapper to my domain layer:

class KomapperBaseRepository<ENTITY : Any, ID : Any, META : EntityMetamodel<ENTITY, ID, META>>(
    private val db: R2dbcDatabase,
    private val entityMetamodel: META,
) : RepositoryBase<ENTITY, ID> {
    override suspend fun create(entity: ENTITY): ENTITY = db.runQuery(QueryDsl.insert(entityMetamodel).single(entity))

    override suspend fun get(id: ID): ENTITY? {
        return db.runQuery(QueryDsl.from(entityMetamodel).where { entityMetamodel...? eq id }.singleOrNull())
    }
}

// on my domain layer:
interface RepositoryBase<T : Any, ID : Any> {
    suspend fun create(entity: T): T

    suspend fun get(id: ID): T?
}

but I can't find what to put in my where as the id property...

[dave08]

I had to add the property here:

class KomapperBaseRepository<ENTITY : Any, ID : Any, META : EntityMetamodel<ENTITY, ID, META>>(
    private val db: R2dbcDatabase,
    private val entityMetamodel: META,
    private val idProperty: PropertyMetamodel<ENTITY, ID, *>
) : RepositoryBase<ENTITY, ID> {
    override suspend fun create(entity: ENTITY): ENTITY = db.runQuery(QueryDsl.insert(entityMetamodel).single(entity))

    override suspend fun get(id: ID): ENTITY? {
        return db.runQuery(QueryDsl.from(entityMetamodel).where {idProperty eq id }.singleOrNull())
    }
}

but maybe there's another way?

[Toshihiro Nakamura]

I do not recommend such standardization because there are very few parts that can be standardized and it is not worth it.

[dave08]

So my implementation where I pass the idProperty is still ok?

[dave08]

You mean in the case where there's composite keys, then it would get more complex?

[Toshihiro Nakamura]

So my implementation where I pass the idProperty is still ok?

Yes, It works fine if you don’t use composite keys.