I'm not sure how I didn't notice this before but w...

# confetti

[John O'Reilly]

I'm not sure how I didn't notice this before but when I switch to different conferences in the Web client (e.g. https://wasm.confetti-app.dev/) it changes theme color for some reason but sessions don't change.....will dig a bit and see if I can see why

[John O'Reilly]

setConference, conference = androidmakers2024
SessionsUiState.Success, conference = KotlinConf 2024

Some state issue...

[John O'Reilly]

I think this is pretty much same code as used in Compose for Desktop client....not sure why it would behave differently here

[John O'Reilly]

hmm, think it's related to change I made in ApolloClientCache here locally where I'm only using in memory cache (as we don't have sqlNormalizedCacheFactory etc on web

[John O'Reilly]

ah, with just MemoryCacheFactory we have nothing to associate with particular conference!

[John O'Reilly]

@mbonnin is there way as a test that I can at least clear in memory cache?

[John O'Reilly]

(when switching conferences)

[mbonnin]

You can clear the cache with apolloClient.apolloStore.clear()

[mbonnin]

I don't see how that would change the behaviour vs Sql though

[John O'Reilly]

yeah, maybe not....I'm not fully clear yet what's happening in this case with just in memory cache

[John O'Reilly]

our UI is driven primarily from cache I believe.....and when we switch conference we should get new client object along with new cache presumably

[John O'Reilly]

strange, commenting out .autoPersistedQueries() seems to "fix" the issue

[mbonnin]

Ah, that might be a CDN thing, I though I put "conference" in the cache key there though 🤔

[John O'Reilly]

this does seem to be specific to the web client for some reason

[mbonnin]

Because APQs use GET, they hit the CDN which is usually good

[mbonnin]

sounds like local browser cache

[John O'Reilly]

compose desktop app for example works fine (just using in memory cache as well in this case)

[mbonnin]

You'll probably want to pass conference as a query param

[mbonnin]

(the backend doesn't support that but that will force it into the browser cache key)

[mbonnin]

serverUrl("<https://confetti-app.dev/graphql?conference=androidmakers2024>)

[mbonnin]

And hope that the query param passes through

[mbonnin]

I should probably add a Vary header too (doc)

[John O'Reilly]

yeah, looks like that works

[mbonnin]

Sorry, I'm a bit new to those browser considerations

[mbonnin]

I added a Vary header there as well. I think it's better to add it: https://github.com/joreilly/Confetti/pull/1298

[John O'Reilly]

so that's an alternative to putting as query param?

[mbonnin]

I hope so

[John O'Reilly]

nice

[John O'Reilly]

is that deployed already? seems to be working now

[mbonnin]

yep

[John O'Reilly]

can get rid of all my println's now 🙂

[John O'Reilly]

the joy of debugging using browser console

[mbonnin]

println never disappoints 😄