currently they only way to use an IntelliJ theme i...
# jewelg
Gary Tierney
04/27/2024, 5:45 PMcurrently they only way to use an IntelliJ theme in a standalone jewel application is by generating a ThemeDefinition at build time (via https://github.com/JetBrains/jewel/blob/main/buildSrc/src/main/kotlin/org/jetbrains/jewel/buildlogic/theme/IntelliJThemeGeneratorPlugin.kt), is there any interest in a PR to expose some of that UI descriptor parsing code to make it possible at runtime or is it something that should live outside of jewel upstream?
s
seb
04/29/2024, 8:42 AMHi Gary, I think that could be interesting, however, it should be in a separate module. Are you thinking about providing runtime custom theming?
seb
04/29/2024, 8:43 AMIt is a non-goal for us for now, since it's not technically possible in Int UI right now and it's sort of undefined how that looks like in practice
g
Gary Tierney
04/29/2024, 8:52 AMAre you thinking about providing runtime custom theming?yeah, that's right, just for compatibility with some existing IntelliJ theme plugins that users might want to use (admittedly I'm not sure how that might look or which ones might be compatible with the new UI either, I've always stuck to IJ's stock dark themes). I'll write it in a separate module for now and see how it actually looks in practice, maybe it can be useful to others in the future
👍 1
s
seb
04/29/2024, 8:53 AMTo be clear, in the bridge module, we do reflect IDE themes just fine, both old and new UI ones. It's only standalone who has hardcoded Light and Dark themes, since those are right now the only Int UI themes that exist officially
g
Gary Tierney
04/29/2024, 9:03 AMyeah, I suppose this is only useful for standalone apps where IJ's theming machinery like JBColor, etc. isn't available. I think what I'll do is implement
ThemeDescriptorIntellijThemeDescriptor💯 1
6 Views