Is this correct if I want to propagate errors but ...

# coroutines

[efemoney]

Is this correct if I want to propagate errors but still know in my finally block that something failed?

val token = acquireLock(state.entityId) ?: return finish()
var failed = false
try {
  doLockBasedOperation()
} catch (e: Exception) {
  failed = true
  throw e
} finally {
  withContext(NonCancellable) {
    releaseLock(state.entityId, token, failed)
  }
}

Will finally still run even though I rethrew in catch block? 🤔

Or am I supposed to duplicate the lock release into the catch block?

[Sam]

That looks fine to me 👍

[efemoney]

Nice, thanks!

[Daniel Pitts]

Yeah, that's the way to do it.

[Daniel Pitts]

Though I might invert that logic a little bit, and set a success flag inside the try block:

val token = acquireLock(state.entityId) ?: return finish()
var success = false
try {
  doLockBasedOperation()
  success = true
} finally {
  withContext(NonCancellable) {
    releaseLock(state.entityId, token, !success)
  }
}

[efemoney]

Hmm makes sense