https://kotlinlang.org logo
Join Slack
Powered by
one question (mostly to maintainers): do we want t...
# arrow-contributors
a
one question (mostly to maintainers): do we want to keep support for 
arrow-retrofit
? There's a well-maintained alternative we could link from the docs, and we have open issues we haven't closed because of lack of knowledge among the team. In addition, 2.0 could be a good moment to say "we no longer support this, migrate to this other library", since we're going to deprecate other stuff too.
d
I personally didn't like that skydoves library when I tried it and ended up with the "official" Arrow implementaiton...
y
I haven't touched Android in quite a while, so I don't think I'll be of much help with that. Not sure if there's active maintainers that have much experience with Retrofit either. As long as no internal changes are really needed to support such adapters, it's good to leave it up to the community while linking to it/recommending it
d
Yeah, I wouldn't remove it, but I'd write that you're looking for a maintainer, and that currently it isn't maintained (for those thinking of using it). But it's a pity, since I think from what I remember is that skydoves is really overkill... a simple implementation is sometimes the best.
j
Retrofit hasn’t changed for a long time, if there are feature requests then it is not a problem “to ignore them”. If they are bugs…
a
the open issue is indeed a bug, but it's been open for almost a year now...
j
The issue you shared is about an user migrating to ktor and asking for a ktor plugin, no?
a
sorry, my bad, the open issue is https://github.com/arrow-kt/arrow/issues/3117
j
The OP is pointing to the serializer, which is unrelated to the adapter so it wouldn’t be a problem of the adapter if that is the case
another problem could be backend returning 205 with body, retrofit deletes the body. I have asked for more details
a
thank you, it would be great to have a fix for this 🙂
j
welcome 🤗
11 Views
Open in Slack
PreviousNext
Powered by