Is there a reason why one is not supposed to creat...

# mvikotlin

[Pavel S]

Is there a reason why one is not supposed to create a store by calling storeFactory.create and instead is supposed to create some factory class with a function returning object : Store<…> by storeFactory.create(…) ?

[Arkadii Ivanov]

This is an option as well. I believe it's documented: https://arkivanov.github.io/MVIKotlin/store.html

Also see the sample: https://github.com/arkivanov/MVIKotlin/blob/196d630778e7629abef242f872f38a7942927ba8/sample/coroutines/shared/src/commonMain/kotlin/com/arkivanov/mvikotlin/sample/coroutines/shared/details/store/DetailsStore.kt#L50

[Arkadii Ivanov]

There are no strict rules here.

[Pavel S]

I think I get it. When you call storeFactory::create directly, it returns an instance of Store<Intent, State, Label> and if it’s used together with instanceKeeper::getStore you get weird `ClassCastException`s in runtime

[Arkadii Ivanov]

I wouldn't expect any exceptions, I think it should work fine. A reproducer would be nice to have.

[Pavel S]

Here. I’ve created a sample with coroutines from your decompose-multiplatform-template, just go to WelcomeComponent and it crashes

[Arkadii Ivanov]

Ah yes thanks! That makes sense actually. The getStore method without arguments uses T::class as key. Since the type is Store and you create two stores under the same InstanceKeeper, it crashes. You need to provide a key for each store in this case, just pass getStore(key = "store1") { ... }. I will play with typeOf instead of KClass and see if it solves the issue.

[Pavel S]

Ok, thanks

[Arkadii Ivanov]

Good news! I was able to use typeOf instead of T::KClass , so it won't crash starting with the next release.

[Arkadii Ivanov]

Released `4.1.0`: https://kotlinlang.slack.com/archives/C01403U1ZGW/p1717765509339569