While trying to migrate KVision to Kotlin 2.0.0 I ...

# javascript

[Robert Jaros]

While trying to migrate KVision to Kotlin 2.0.0 I have strange runtime errors when dealing with some large data classes. See thread.

[Robert Jaros]

ColumnDefinition.<init>' can not be called: No constructor found for symbol 'io.kvision.tabulator/ColumnDefinition.<init>|<init>(kotlin.String;kotlin.String?;kotlin.collections.List<io.kvision.tabulator.ColumnDefinition<1:0>>?;kotlin.Boolean?;io.kvision.tabulator.Align?;kotlin.String?;kotlin.Int?;kotlin.Int?;kotlin.Int?;<dynamic>;kotlin.Boolean?;kotlin.Int?;<dynamic>;kotlin.String?;kotlin.Boolean?;kotlin.Boolean?;io.kvision.tabulator.Sorter?;kotlin.Function7<kotlin.Nothing?,kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.RowComponent,io.kvision.tabulator.js.Tabulator.RowComponent,io.kvision.tabulator.js.Tabulator.ColumnComponent,io.kvision.tabulator.SortingDir,kotlin.Nothing?,kotlin.Number>?;<dynamic>;io.kvision.tabulator.Formatter?;kotlin.Function3<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Nothing?,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,<dynamic>>?;kotlin.Function3<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,1:0,io.kvision.core.Component>?;<dynamic>;kotlin.Boolean?;kotlin.Function1<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Boolean>?;io.kvision.tabulator.Editor?;kotlin.Function5<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,kotlin.Function1<kotlin.Nothing?,kotlin.Unit>,kotlin.Function1<kotlin.Nothing?,kotlin.Unit>,kotlin.Nothing?,<dynamic>>?;kotlin.Function5<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,kotlin.Function1<kotlin.Nothing?,kotlin.Unit>,kotlin.Function1<kotlin.Nothing?,kotlin.Unit>,1:0,io.kvision.core.Component>?;<dynamic>;io.kvision.tabulator.Validator?;<dynamic>;kotlin.String?;<dynamic>;kotlin.String?;io.kvision.tabulator.Calc?;<dynamic>;io.kvision.tabulator.Formatter?;<dynamic>;io.kvision.tabulator.Calc?;<dynamic>;io.kvision.tabulator.Formatter?;<dynamic>;kotlin.Boolean?;io.kvision.tabulator.SortingDir?;kotlin.Boolean?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.ColumnComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.ColumnComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.ColumnComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.ColumnComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.ColumnComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.ColumnComponent,kotlin.Unit>?;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;io.kvision.tabulator.Formatter?;kotlin.Function3<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Nothing?,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,<dynamic>>?;kotlin.Function2<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,io.kvision.core.Component>?;<dynamic>;io.kvision.tabulator.Editor?;<dynamic>;kotlin.Function5<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,kotlin.Function1<kotlin.Nothing?,kotlin.Unit>,kotlin.Function1<kotlin.Nothing?,kotlin.Unit>,kotlin.Nothing?,<dynamic>>?;kotlin.String?;kotlin.Function1<kotlin.Any,kotlin.Boolean>?;io.kvision.tabulator.Filter?;kotlin.Function4<kotlin.Nothing?,kotlin.Nothing?,kotlin.Nothing?,kotlin.Nothing?,kotlin.Boolean>?;<dynamic>;kotlin.Boolean?;<dynamic>;<dynamic>;kotlin.Function3<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Nothing?,kotlin.Function1<kotlin.Function0<kotlin.Unit>,kotlin.Unit>,<dynamic>>?;<dynamic>;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function2<kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function1<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function1<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;kotlin.Function1<io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Unit>?;<dynamic>;<dynamic>;<dynamic>;io.kvision.tabulator.Align?;io.kvision.tabulator.VAlign?;<dynamic>;io.kvision.tabulator.Align?;<dynamic>;<dynamic>;kotlin.Int?;kotlin.Function5<kotlin.Nothing?,kotlin.Nothing?,kotlin.String,kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Any>?;<dynamic>;kotlin.Function5<kotlin.Nothing?,kotlin.Nothing?,kotlin.String,kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Any>?;<dynamic>;kotlin.Function5<kotlin.Nothing?,kotlin.Nothing?,kotlin.String,kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Any>?;<dynamic>;kotlin.Function5<kotlin.Nothing?,kotlin.Nothing?,kotlin.String,kotlin.Nothing?,io.kvision.tabulator.js.Tabulator.CellComponent,kotlin.Any>?;<dynamic>;kotlin.Int?;<dynamic>;<dynamic>;<dynamic>;<dynamic>;<dynamic>;<dynamic>;<dynamic>;kotlin.Boolean?;<dynamic>;<dynamic>;<dynamic>;<dynamic>;<dynamic>;<dynamic>;kotlin.Boolean?;kotlin.String?;kotlin.String?){}[0]'

[Robert Jaros]

or

[Robert Jaros]

IrLinkageError: Constructor 'TabulatorOptions.<init>' can not be called: No constructor found for symbol 'io.kvision.tabulator/TabulatorOptions.<init>|<init>(kotlin.String?;kotlin.String?;kotlin.Function0<kotlin.String?>?;kotlin.String?;kotlin.String?;kotlin.Boolean?;<dynamic>;<dynamic>;io.kvision.tabulator.DownloadConfig?;kotlin.Boolean?;kotlin.Boolean?;kotlin.collections.List<io.kvision.tabulator.ColumnDefinition<1:0>>?;kotlin.Boolean?;kotlin.Boolean?;io.kvision.tabulator.Layout?;kotlin.Boolean?;io.kvision.tabulator.ResponsiveLayout?;kotlin.Boolean?;kotlin.Boolean?;kotlin.Boolean?;io.kvision.tabulator.ColumnPosition?;kotlin.Boolean?;kotlin.Function1<io.kvision.tabulator.js.Tabulator.RowComponent,kotlin.Unit>?;io.kvision.tabulator.RowPos?;<dynamic>;io.kvision.tabulator.RangeMode?;kotlin.Boolean?;kotlin.Boolean?;kotlin.Function1<io.kvision.tabulator.js.Tabulator.RowComponent,kotlin.Boolean>?;kotlin.Boolean?;<dynamic>;<dynamic>;<dynamic>;kotlin.Boolean?;io.kvision.tabulator.RowPosition?;kotlin.Boolean?;kotlin.String?;kotlin.Array<1:0>?;kotlin.String?;<dynamic>;<dynamic>;<dynamic>;kotlin.Function3<kotlin.String,kotlin.Nothing?,kotlin.Nothing?,kotlin.String>?;kotlin.Function3<kotlin.String,kotlin.Nothing?,kotlin.Nothing?,kotlin.js.Promise<kotlin.Any>>?;io.kvision.tabulator.ProgressiveMode?;kotlin.Int?;kotlin.Int?;kotlin.Boolean?;kotlin.String?;kotlin.String?;kotlin.collections.List<io.kvision.tabulator.js.Tabulator.Sorter>?;kotlin.Boolean?;kotlin.collections.List<io.kvision.tabulator.js.Tabulator.Filter>?;kotlin.collections.List<kotlin.Any?>?;kotlin.Boolean?;io.kvision.tabulator.PaginationMode?;kotlin.Int?;<dynamic>;<dynamic>;<dynamic>;<dynamic>;io.kvision.tabulator.AddRowMode?;kotlin.Int?;kotlin.String?;kotlin.Boolean?;kotlin.Boolean?;kotlin.Boolean?;kotlin.Boolean?;kotlin.String?;<dynamic>;kotlin.Function2<kotlin.String,kotlin.Nothing?,kotlin.Unit>?;kotlin.Boolean?;<dynamic>;kotlin.Boolean?;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;kotlin.String?;kotlin.String?;kotlin.Function2<kotlin.Nothing?,kotlin.Nothing?,kotlin.Unit>?;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;kotlin.String?;<dynamic>;<dynamic>;kotlin.String?;<dynamic>;kotlin.Number?;kotlin.Function2<io.kvision.tabulator.js.Tabulator.RowComponent,kotlin.Number,kotlin.Boolean>?;kotlin.Function2<kotlin.String,kotlin.Nothing?,kotlin.Boolean>?;kotlin.Function3<kotlin.String,kotlin.Nothing?,kotlin.Nothing?,kotlin.Any>?;<dynamic>;<dynamic>;<dynamic>;kotlin.Int?;io.kvision.tabulator.VAlign?;kotlin.String?;kotlin.String?;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;kotlin.Int?;io.kvision.tabulator.TextDirection?;<dynamic>;<dynamic>;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;io.kvision.tabulator.RenderType?;kotlin.Int?;io.kvision.tabulator.RenderType?;io.kvision.tabulator.ColumnDefinition<1:0>?;io.kvision.tabulator.SortMode?;io.kvision.tabulator.FilterMode?;io.kvision.tabulator.ImportFormat?;io.kvision.tabulator.ImportReader?;kotlin.Int?;<dynamic>;<dynamic>;<dynamic>;<dynamic>;<dynamic>;kotlin.Boolean?;kotlin.Int?;<dynamic>;kotlin.String?;io.kvision.tabulator.HeaderSortClickElement?;<dynamic>;<dynamic>;kotlin.Function1<kotlin.Array<<dynamic>>,org.w3c.dom.Element>?;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;kotlin.Boolean?;kotlin.String?;io.kvision.tabulator.EditTriggerEvent?;<dynamic>;kotlin.Boolean?;kotlin.Int?;kotlin.Int?;<dynamic>;<dynamic>;kotlin.Boolean?;<dynamic>;kotlin.Boolean?;kotlin.Boolean?;kotlin.Boolean?;<dynamic>;kotlin.Function1<<dynamic>,kotlin.Boolean>?){}[0]'

[Robert Jaros]

The classes are defined in this file: https://github.com/rjaros/kvision/blob/master/kvision-modules/kvision-tabulator/src/jsMain/kotlin/io/kvision/tabulator/Options.kt

[Robert Jaros]

The compilation doesn't give any warnings or errors, but the application fails at runtime (including tests).

[turansky]

Will it work if use Any? instead of dynamic ?

[Robert Jaros]

I've managed to identify the problem - any property of a function type with dynamic parameter.

[Robert Jaros]

e.g. val ajaxURLGenerator: ((url: String, config: dynamic, params: dynamic) -> String)? = null

[Robert Jaros]

replacing this dynamic with Any? fixes the issue

[turansky]

Cool! :)

[Robert Jaros]

Not cool 🙂

[Robert Jaros]

I need those dynamics 🙂

[turansky]

In common case it's your internal details

[Robert Jaros]

In my case it's a public api of KVision components.

[turansky]

Any? works fine in most cases :)

[Robert Jaros]

The important question - is it Kotlin/JS bug? Or just a feature of K2 I need to live with.

[turansky]

Will you create issue?

[Robert Jaros]

I've tried to create a simplified reproducer, but failed to do this. It works fine in simple scenarios.

[Robert Jaros]

e.g. here:
https://pl.kotl.in/Y0_VTesGY

[Robert Jaros]

But it doesn't work in KVision and I don't know why.

[Robert Jaros]

I've replaced all dynamic parameters with Any? and both the library and the app work. But before I had val cellClick: ((e: dynamic, cell: Tabulator.CellComponent) -> Unit)? = null and I could easily use it like this:

cellClick = { evt: Event, cell ->
    evt.preventDefault()
}

[Robert Jaros]

When changing to e: Any? I can't do this anymore.

[turansky]

Easily = unsafe

[Robert Jaros]

That's what dynamic is for 😉

[turansky]

That's what doesn't work :)

[Robert Jaros]

I think I need to fill an issue giving KVision branch as a reproducer 🙂

[turansky]

Your example looks like example of invalid call

[turansky]

In fact you changed parameter type

[turansky]

And it's illegal

[Robert Jaros]

with 1.9 it works fine without even a single warning from the compiler or IDE

[turansky]

New compiler works better :)

[turansky]

Missed warning is problem

[turansky]

But type processing is fine

[Robert Jaros]

No. New compiler doesn't work better. It works the same way: https://pl.kotl.in/svMiZo8rm

[Robert Jaros]

It tries to work "better" only in KVision. And that's a bug in my opinion.

[turansky]

Robert,
Current behavior of Kotlin in case of dynamic parameters in lambdas - bug
You can abuse current behavior, but you must be ready for such problems which you have and for possible fix in future

[Robert Jaros]

I'll probably go with Any?, because I don't have much hope for a quick fix without a simple reproducer. I'll have a major release anyway, so I can live with "small" breaking changes 😉

[aerialist]

@Robert Jaros, did you report this issue to Kotlin team?

[Robert Jaros]

No I didn't. I can't create a simple reproducer. Do you think it's worth reporting anyway?

[aerialist]

@Robert Jaros, of course.
Moreover, Victor confirmed that this is a bug, so please create an issue on YouTrack to Kotlin team

[turansky]

Good practice in common - don't use dynamic in parameters and properties.
We will add issue in FAQ as additional argument 😜

[Robert Jaros]

https://youtrack.jetbrains.com/issue/KT-68740/Kotlin-JS-2.0.0-IrLinkageError-with-dynamic-function-parameters-inside-data-classes

[aerialist]

True, if it’s your responsibility, then using `dynamic`’s looks weird, you should avoid them.
But in the case of third-parties, when you can’t influence the library author, or it’s probably deprecated/not updated, then K2 should not break existing code.

Thank you for the report!

[Edoardo Luppi]

dynamic should still work perfectly, it's an integral part of the JS interop

[Edoardo Luppi]

AFAIR there is dynamic usage in the stdlib too, but I think it's not yet compiled with K2