Little detail... when there's a mistake in the con...
# komapper
d
Little detail... when there's a mistake in the connection url... Komapper just prints the whole url out to the logs... when using
username:password@...
it shows the password in plain text. It would be nice if it could just replace the password with *...
I had a ^ in the password, so
ConnectionFactoryOptions.parse
failed to parse it.
t
Is Komapper printing that URL? If it is being output as a stack trace, could you show me that stack trace?
d
No, it's not Komapper... it's coming from
ConnectionFactoryOptions.parse
(just paste that in a scratch file and add a ^ to the password, and you'll see the stack trace...). I understand that it might not be Komapper's responsibility to filter or catch such errors... but when using the url overload I think users think it'll just "work" (especially since Komapper itself IS careful about such things with
masking *=*
true
in columns
), it might be nice to just catch that and rethrow it with the password not in clear text...?
But I opened an issue in r2dbc anyways... https://github.com/r2dbc/r2dbc-spi/issues/286