Would you consider having `Enum<E>.qualifier...

# koin

[Eugen Martynov]

Would you consider having Enum<E>.qualifier relating to the default Locale is dangerous?

[Eugen Martynov]

I mean

val <E : Enum<E>> Enum<E>.qualifier
    get(): Qualifier {
        return StringQualifier(this.toString().toLowerCase())
    }

is locale specific. Maybe use .lowercase() that is using Locale.ROOT?

[LeoColman]

what's the matter with using .name() and calling it a day?

[Eugen Martynov]

That would probably be a breaking change. But I'm fine with it

[LeoColman]

Ah, you mean on Koin itself. For some reason I thought this was you function

[Eugen Martynov]

It is koin code

[LeoColman]

I think it wouldn't be a problem until the Locale is changed during runtime, and even in that case my guess is that the tree is just rebuilt with the new qualifier. I guess it's also very unlikely to get 'bad' names coming from enum constants, but many things are allowed xD


Is it dangerous? I'd say no. Most likely not.

Is it correct? No. The implementation could probably address these corner cases and others

[Eugen Martynov]

Haha, we had a bug where the qualifier was saved in JSON. And that gave us problems.

[LeoColman]

Like having user in country A producing a different qualifier than user in country B, and then crossing data around didn't fit?

In that case, still not dangerous, but worthy of an issue 😄

[Eugen Martynov]

User in the same country but has a Turkish locale. Anyway, I will better create a ticket in the koin GitHub with all details.

[Eugen Martynov]

A bit late but here it is https://github.com/InsertKoinIO/koin/issues/1931