`Dialog` seems to ignore the density values in `LocalDensity` for its content. :thread:

# compose

[ryan.fonzi]

Dialog seems to ignore the density values in LocalDensity for its content. 🧵

[ryan.fonzi]

i.e. Something like

CompositionLocalProvider(LocalDensity provides Density(1.5f, 1.5f)) {
    // other content

    Dialog(..) {
        // dialog content
    }
}

..will scale whatever's in "other content", but "dialog content" remains unscaled.
But if you re-wrap the dialog content it works on both:

CompositionLocalProvider(LocalDensity provides Density(1.5f, 1.5f)) {
    // other content

    
    Dialog(..) {
        CompositionLocalProvider(LocalDensity provides Density(1.5f, 1.5f)) {
            // dialog content
        }
    }
}

Is this a bug or intentional?

[ryan.fonzi]

This is with compose ui 1.2.0-beta03

[Dominaezzz]

It's possible that composition locals aren't being passed through.

[ryan.fonzi]

Some are. Theming doesn't look like it's broken.

[Dominaezzz]

Ah I see.

[ryan.fonzi]

I wonder if it's because of a weird interaction with the dialog window. The device configuration hasn't changed, just the LocalDensity.

[Dominaezzz]

Is Popup available on Android?

[ryan.fonzi]

Pretty sure that's how DropdownMenu works. Lemme try that.

[ryan.fonzi]

The popup isn't affected by LocalDensity either

[ryan.fonzi]

so it is a window thing

[Dominaezzz]

Yeah that's interesting.

[ryan.fonzi]

I don't even know if this is incorrect behavior. The system's own density is consistent with these windows. I'm just overriding it within the context of my own app.

[ryan.fonzi]

i guess you could say i'm providing the content, so the dialog's behavior is incorrect if i expect that content to be scaled consistently with the rest of my app