https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
l

Lukasz Kalnik

08/02/2022, 1:39 PM
I'm using Retrofit's
MoshiConverterFactory
for my API calls, however it doesn't support sealed classes containing `object`s. I'm trying to generate adapters for the sealed class hierarchy using
moshi-sealed
, but I still get the error
object Always cannot be serialized
. Here the hierarchy:
@Keep
@JsonClass(generateAdapter = true, generator = "sealed:type")
sealed class TriggerCondition(val type: String) : Serializable {

    @Keep
    @TypeLabel("ALWAYS")
    object Always : TriggerCondition("ALWAYS")

    @Keep
    @TypeLabel("NIGHT")
    object Night : TriggerCondition("NIGHT")

    @Keep
    @TypeLabel("LIGHT_SENSOR")
    @JsonClass(generateAdapter = true)
    data class LightSensor(
        val sensorInfo: SensorInfo,
    ) : TriggerCondition("LIGHT_SENSOR")
}
z

Zac Sweers

08/02/2022, 1:43 PM
This isn't enough info to help. How are you configuring your retrofit and Moshi instances? How are you defining your retrofit endpoint?
l

Lukasz Kalnik

08/02/2022, 1:44 PM
fun create(client: OkHttpClient, baseUrl: String): AirConnectorApi =
            Retrofit.Builder()
                .baseUrl(baseUrl)
                .client(client)
                .addConverterFactory(MoshiConverterFactory.create(moshiForKotlin))
                .addCallAdapterFactory(EitherCallAdapterFactory())
                .build()
                .create(AirConnectorApi::class.java)
val moshiForKotlin = Moshi.Builder()
    .add(KotlinJsonAdapterFactory())
    .build()
This is the stack trace:
java.lang.IllegalArgumentException: Unable to create converter for class myapp.gatewayapi.data.remote.air.model.AutomationList
                     for method AirConnectorApi.getAutomations
                 	at retrofit2.Utils.methodError(Utils.java:54)
                 	at retrofit2.HttpServiceMethod.createResponseConverter(HttpServiceMethod.java:126)
                 	at retrofit2.HttpServiceMethod.parseAnnotations(HttpServiceMethod.java:85)
                 	at retrofit2.ServiceMethod.parseAnnotations(ServiceMethod.java:39)
                 	at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:202)
                 	at retrofit2.Retrofit$1.invoke(Retrofit.java:160)
                 	at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
                 	at $Proxy12.getAutomations(Unknown Source)
                 	at myapp.gatewayapi.data.remote.air.AirConnectorApi$DefaultImpls.getAutomations$default(AirConnectorApi.kt:142)
                 	at myapp.gatewayapi.data.remote.common.CommonConnectorApiAirImpl.getAutomations(CommonConnectorApiAirImpl.kt:267)
                 Caused by: java.lang.IllegalArgumentException: Cannot serialize object declaration myapp.gatewayapi.data.remote.air.model.TriggerCondition$Always
                 for class myapp.gatewayapi.data.remote.air.model.TriggerCondition triggerCondition
                 for class myapp.gatewayapi.data.remote.air.model.SensorTrigger
                 for interface myapp.gatewayapi.data.remote.air.model.AutomationTrigger trigger
                 for class myapp.gatewayapi.data.remote.air.model.ExistingAutomation
                 for java.util.List<myapp.gatewayapi.data.remote.air.model.ExistingAutomation> items
                 for class myapp.gatewayapi.data.remote.air.model.AutomationList
Containing class
ExistingAutomation
just implements
Serializable
, it's not annotated with
@JsonClass(...)
z

Zac Sweers

08/02/2022, 2:08 PM
That stacktrace is complaining about something called AutomationList
l

Lukasz Kalnik

08/02/2022, 2:10 PM
Yes, that's the return type of the Retrofit API call
z

Zac Sweers

08/02/2022, 2:10 PM
How is that class defined? It's not in your snippets above
l

Lukasz Kalnik

08/02/2022, 2:10 PM
data class AutomationList(
    val total: Int,
    val items: List<ExistingAutomation>
)
z

Zac Sweers

08/02/2022, 2:11 PM
And existingautomation?
l

Lukasz Kalnik

08/02/2022, 2:11 PM
sealed interface Automation : Serializable {

    val name: String
    val trigger: AutomationTrigger
    val command: Command?
}

data class ExistingAutomation(
    val id: String,
    override val name: String,
    override val trigger: AutomationTrigger,
    override val command: Command?,
    @Json(name = "pending_state") val pendingState: DeviceState? = null,
    @Json(name = "provisioning_complete") val provisioningComplete: Boolean? = null,
    @Json(name = "provisioning_states") val provisioningStates: List<ProvisioningState>? = null,
) : Automation
But why is there:
Caused by: java.lang.IllegalArgumentException: Cannot serialize object declaration myapp.gatewayapi.data.remote.air.model.TriggerCondition$Always
in my stacktrace?
z

Zac Sweers

08/02/2022, 2:13 PM
I don't know
l

Lukasz Kalnik

08/02/2022, 2:13 PM
It points to `object
Always
So for me it looks as though the Retrofit
MoshiConverterFactory
was not able to cooperate with
moshi-sealed
annotated classes
z

Zac Sweers

08/02/2022, 2:14 PM
I don't see anything obviously wrong there, but there may be other issues in your build. If you can make a reproducible sample that would help
l

Lukasz Kalnik

08/02/2022, 2:14 PM
Ok, thanks for the help!
z

Zac Sweers

08/02/2022, 2:14 PM
Moshi converter factory works fine with Moshi-sealed
l

Lukasz Kalnik

08/02/2022, 2:15 PM
Do I have to register some special adapters with my Moshi instance to use moshi-sealed?
z

Zac Sweers

08/02/2022, 2:15 PM
Only if you use reflection
But your snippet says you're using code gen
l

Lukasz Kalnik

08/02/2022, 2:16 PM
Yes
Ok, thank you very much for you time!
I will try to figure it out.