Just released 0 5 0

Question

Just released 0 5 0 <https github com evant kotlin inject releases tag v0 5 0>

Paul Woitaschek · Answer

Nice tada The native publication seems broken <https github com evant kotlin inject issues 222>

dave08 · Answer

Tried upgrading and encountered those new errors with parent child components even though it was working well with 0 4 0 is it for sure a mistake in all cases to ignore those errors

Paul Woitaschek · Answer

Yeah probably they shouldn t be ignored Or the warnings are wrong in that case a reproducer would be top thumbsup

eygraber · Answer

Gonna have to make some big changes due to parents not being able to use child injections but I d much rather have the safety of not leaking so grin

Paul Woitaschek · Answer

gt Gonna have to make some big changes due to parents not being able to use child injections Can you give an example That should still work

eygraber · Answer

From the release notes gt In other words a parent component can no longer depend on a dependency provided by a child component Not only does this lead to confusing graphs but it can lead to memory leaks if the parent component lives longer than the child and ends holding on to that child dependency

Paul Woitaschek · Answer

But why would you do that in the first place

eygraber · Answer

I was porting concepts from runtime frameworks for Kodein and it was the only way to get it to work

eygraber · Answer

It was much easier than restructuring everything in my app head

Paul Woitaschek · Answer

Still can t think of a practical example ^^

eygraber · Answer

When I update my code I ll try to remember to post the scenario here

evant · Answer

Oof sorry about that native publication getting messed up I fixed one issue with it before release but missed that

Paul Woitaschek · Answer

< evant> Are you already onto this

Paul Woitaschek · Answer

I couldn t reproduce it locally so it might be related to that nexus stuff Is that nexus plugin even necessary

evant · Answer

Yeah will take a look either today or tomorrow I think it s only the mac build Which is weird

Paul Woitaschek · Answer

On my mac publishToMavenLocal creates correct publications

evant · Answer

And yeah with kotlin multiplatform the nexus plugin is basically required cause otherwise I ve run into issues where it will randomly split artifacts across publications

Paul Woitaschek · Answer

Paul Woitaschek · Answer

Sqldelight seems to do it without the nexus one

evant · Answer

< Paul Woitaschek> I think I have a fix but don t have a kmm project handy at the moment mind verifying that 0 5 1 SNAPSHOT works now when you get a chance

Paul Woitaschek · Answer

Yep building

Paul Woitaschek · Answer

``` public override val welcomeScreenViewModelFactory WelcomeScreenViewModel Factory get = WelcomeScreenViewModel Factory creator = arg0 gt WelcomeScreenViewModel dispatcherProvider = dispatcherProvider localizer = localizer remoteConfig = remoteConfig tracker = WelcomeTracker tracker = tracker screenTracker = screenTracker navigator = arg0 ``` smile

evant · Answer

Oh is it making the names unique across the whole component

Paul Woitaschek · Answer

Yes Is that a problem

evant · Answer

I mean it ll work but it probably could be improved to take scope into account to make them shorter

Paul Woitaschek · Answer

I d prefer to leave it like this because it doesn t cause issues and is simple to read and test Else we d need a way more complex test setup and it would make the processor way more complex as well

evant · Answer

Long identifiers lead to code bloat in the executable I mean you could use proguard to fix but not everyone is I really don t think it would be that complicated but yeah not the highest priority

evant · Answer

Paul Woitaschek · Answer

Thanks tada Im on vacation now but the renovate PR is all green