Hey, I've added a very small but convenient extens...

# kotest

[Chad Moller]

Hey, I've added a very small but convenient extension to provide scope in an assertSoftly block

inline fun <T, R> T.assertSoftly(assertions: T.() -> R): R {
   return io.kotest.assertions.assertSoftly { this.assertions() }
}

Are there any thoughts or objections about adding this to kotest, along with other similar scoping functions?

An example of its use:

val user = buildUser()
user.assertSoftly {
    name shouldBe "Bob"
    role shouldBe Role.ADMIN
}

[sam]

I thought we had that already tbh

[sam]

but if not, seems worthwhile to add.

[LeoColman]

No no no

[LeoColman]

We had a big issue because of that

[LeoColman]

Let me find the reason why

[Chad Moller]

Thanks for the quick reply! I'm curious what problems that code could cause

[LeoColman]

I think it messed up with other kind of tests, kind of overriding the context

[LeoColman]

https://github.com/kotest/kotest/commit/ed570a2b460ad7f8de716bb05988aa92f0a5af3e

[LeoColman]

It was added in this commit, I'm still to find the reversal

[LeoColman]

inline fun <S, T> S.assertSoftly(crossinline assertions: S.() -> T): T = assertSoftly( { assertions() } as () -> T )

[LeoColman]

It even has the same signature you proposed, @Chad Moller

[LeoColman]

https://github.com/kotest/kotest/commit/b07e406b30bd2d7f3517816616fb4fe2980df2de

This was the reversal commit

[LeoColman]

https://github.com/kotest/kotest/issues/1831

[LeoColman]

This was one of the issues reporting the bugs we had with it

[LeoColman]

@Ashish Kumar Joy Do you remember this?

[Chad Moller]

I'm going to play with this later! I'm curious!!

[Ashish Kumar Joy]

@LeoColman That issue was discussed here https://kotlinlang.slack.com/archives/CSYLDDZUY/p1594489972146700

[sam]

You have a good memory @LeoColman!
What is the tl;dr on the issue ?

[LeoColman]

I think the gist of it is that having the second case would always pass Spec as this if you want to use the other case

[LeoColman]

Nice find @Ashish Kumar Joy! I searched in this channel but didn't think of #kotest-contributors

[Chad Moller]

So if I read that correctly, it was an overloading issue. Thanks for the info! You probably saved me some future headaches here.

Any thoughts on using a unique name for the receiver object version?

assertSoftlyRun, or similar?

[sam]

Apply is the kotlin stblib name for it

[sam]

assertSoftlyApply ?

[sam]

applyAssertSoftly

[Chad Moller]

I only mentioned run because of the return value. Apply returns the context object itself which shouldn't really matter in this use case that I can think of

[sam]

That's fair

[Chad Moller]

And certainly apply makes more grammatical sense

[LeoColman]

applySoftly sounds cute

[LeoColman]

assertedSoftly?

[LeoColman]

as in "foo".assertedSoftly { }

[LeoColman]

foo.assertingSoftly{}

[Chad Moller]

"Apply softly" are instructions for lotion

[Chad Moller]

I like all those options tho

[sam]

what about the original name, and just assertSoftly(object) { }

[LeoColman]

I mean, it's what we have today hahahah