https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
e

Emil Kantis

08/10/2022, 10:02 PM
Hey.. Is there any good pattern for this use case? I have an API that returns an
Employee
for instance.. I want it to have non-null values for a lot of fields which actually are nullable in the underlying system. So I would like to have my client deserialize the API response into a
User
and then use a
toEmployee
method that returns a
ValidatedNel<Problem, Employee>
.. More in thread.
My
Employee
class looks like:
data class Employee(
   val id: UInt,
   val firstName: String,
   val lastName: String,
   val workEmail: String,
   val supervisorId: UInt,
   val ssn: String,
   val teamId: UInt?,
   val teamName: String?,
   val personalEmail: String?,
   val phone: String?,
   val bankClearingNumber: String,
   val bankAccountNumber: String,
   val taxationTable: UInt,
   val address: String,
   val zipCode: String,
   val city: String,
   val employmentAgreements: List<EmploymentAgreement>,
   val children: List<Child>,
   @SerialName("salary")
   val salaries: List<Salary>,
)
but it turns out everything but id is nullable.. so the
User
class looks like:
@Serializable
data class User(
   val id: UInt,
   val firstName: String?,
   val lastName: String?,
   val workEmail: String?,
   val supervisorId: UInt?,
   val ssn: String?,
   val teamId: UInt?,
   val teamName: String?,
   val personalEmail: String?,
   val phone: String?,
   val bankClearingNumber: String?,
   val bankAccountNumber: String?,
   val taxationTable: UInt?,
   val address: String?,
   val zipCode: String?,
   val city: String?,
   val employmentAgreements: List<EmploymentAgreement>,
   val children: List<Child>,
   @SerialName("salary")
   val salaries: List<Salary>,
) {
   fun toEmployee(): ValidatedNel<Exception, Employee> = TODO()
}
Zipping everything field by field feels very tedious? 🙂
s

simon.vergauwen

08/11/2022, 6:34 AM
Zipping everything field by field feels very tedious?
You can probably write some more generic for your use-case using
memberProperties
. https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.reflect.full/member-properties.html Something that iterates over all properties, and validates them while collecting the
Invalid
. If the resulting
List<Invalid>
is empty, then you can construct the
Valid
case.
It's not something that exists in Arrow, and probably shouldn't but could work well for your use-case. If you don't need this pattern a lot, I would just opt for the bit of
zip
boilerplate. It's what I typically see as the "necessary evil" to be precise, and total in all my functions.
s

stojan

08/11/2022, 6:47 AM
Another alternative is to not write a dto and write a converter instead https://github.com/uberto/kondor-json
e

Emil Kantis

08/11/2022, 6:54 AM
I suppose I could do that. I'm already using kotlinx serialization everywhere though, but I guess the pattern can be used there as well
Thanks guys, I think I'll try out both approaches and see how it ends up looking 🙂
@simon.vergauwen wont I run into issues with zipping due to too many properties? IIRC those methods have a max of 14 params or something?
s

simon.vergauwen

08/11/2022, 7:20 PM
They indeed have a limit, but you can easily compose them further by using an intermediate tuple.
validatedA.zip(
  ...,
  validatedJ.zip(validatedK, validatedL, ::Triple)
) { a, b, c, d, e, f, g, h, i, (j, k, l) -> ... }
e

Emil Kantis

08/11/2022, 7:32 PM
Was hoping to use the constructor ref, guess that wont be doable 😞 Running into lots of duplication of the names. Aside from that, I think this is working quite nicely 🙂
fun EmployeeDTO.validated(): ValidatedNel<String, Employee> {
   val validatedFirstName = fromNullable(firstName) { "Missing first name" }.toValidatedNel()
   val validatedLastName = fromNullable(lastName) { "Missing last name" }.toValidatedNel()
   val validatedEmail = fromNullable(workEmail ?: personalEmail) { "Missing email" }.toValidatedNel()
   val validSsn = fromNullable(ssn) { "Missing SSN" }.toValidatedNel()
   val validBankClearingNumber = fromNullable(bankClearingNumber) { "Missing bank clearing number " }.toValidatedNel()
   val validBankAccountNumber = fromNullable(bankAccountNumber) { "Missing bank account number " }.toValidatedNel()
   val validTaxationTable = fromNullable(taxationTable) { "Missing taxation table" }.toValidatedNel()
   val agreements = employmentAgreements.map { it.validated() }.sequence()

   return id.validNel().zip(
      validatedFirstName,
      validatedLastName,
      validatedEmail,
      supervisorId.validNel(),
      validSsn,
      phone.validNel(),
      validBankClearingNumber,
      validBankAccountNumber,
      validTaxationTable,
      agreements,
      children.validNel(),
      salaries.validNel(),
      ::Employee,
   )
}
Suppose I can wrap some of the data into some other data class though, since it's split from the response model of the API now
s

simon.vergauwen

08/12/2022, 7:14 AM
Was hoping to use the constructor ref, guess that wont be doable
You can easily do this if you define a
zip
method with the same arity as the constructor. Let's say a
data class
with
12
properties. Granted.. it's rather boilerplate'y but also why we choose to limit to 9 params.. Otherwise it becomes really bloated in Arrow Core.
fun <E, A, B, C, D, E, F, G, H, I, J, K, L, M> Validated<E, A>.zip(
  validatedB: Validated<E, B>, validatedC: Validated<E, C>, ....
) = zip(
  ...,
  validatedJ.zip(validatedK, validatedL, ::Triple)
) { a, b, c, d, e, f, g, h, i, (j, k, l) -> ... }