<@UJNU95VNC> Sorry to ping here but <https://andro...
# compose
t
@shikasd Sorry to ping here but https://android-review.googlesource.com/c/platform/frameworks/support/+/3160211 have side effect and retrigger a text issue (https://issuetracker.google.com/issues/308501489#comment10) Since there's no Google reaction in that issue, I'm not sure it's followed and it would have get back to you.
s
Thanks for pinging me here, I was unaware of this issue Will investigate on Monday cc @Halil Ozercan @Zach Klippenstein (he/him) [MOD]
t
That issue existed before under other circumstances that did not touch me. Your CL has enabled the issue for other cases it seems, so not sure it's your fault but you are easier to ping than Sean.
Have a nice week end.
s
Yeah, so far it looks like it was drawn without being placed, I am not sure why we schedule draw in this case though Worth investigating for sure
👍 1
t
Since your not in CC of the initial issue. opened https://issuetrdrawWithContentacker.google.com/issues/353167430 , the related code use Placeholder that use
drawWithContent
.
👍 1
BTW this week end I also quickly reported https://issuetracker.google.com/issues/352700379 that have Lazy in the crash, maybe it's for you or Andrey too.
s
Thanks for reporting that as well :) Unfortunately it is one of those race condition crashes that consumes original exception. It does not give us any info about the original, but maybe there's a regression of similar magnitude happening at the same time?
Also running Compose snapshots in prod is... Very brave 😉
t
I unfortunately do not have choices, I keep reporting issues since mid 1.7 and each time there's a fix there's another crash I report and so on. I hope that if you can fix the regression from your last CL I'll be able to settle on 1.8 A1 :)
I also reported a couple other issues waiting for triage. But except what it seems more memory consumption I do not see other crashes that could be related.
s
I am going to revert the change for now, will investigate it more
t
Thanks, extracting a repro from code that deep is complicated, but I can repro usually within a couple of fastscroll, so can easily test anything if needed.
@Andrey Kulikov shot in the dark but I've reported https://issuetracker.google.com/issues/353538515 that also occurs with LazyList and placeholders and tied to things not attached but still in the tree. No idea if it can be related as I do not understand that part at all, but just in case it can help with the root cause.
Arf sorry I mean @shikasd 😞
s
Yeah, this is unrelated unfortunately, since in our case we don't detach nodes
😞 1