For navigation compose type safe, has anyone written lint checks for common mistakes (using nested s...

# compose

[agrosner]

For navigation compose type safe, has anyone written lint checks for common mistakes (using nested serialized classes without nav types, enums, unsupported parameter types even though valid in kotlinx serialization)?

[agrosner]

Having runtime crashes are not fun, which can get mitigated by an integration test

[Ian Lake]

Note that the later two are going to be handled for you in this next beta: enums and every type are going to be supported by default

[agrosner]

By “every type” do you mean everything kotlinx serialization supports?

[Ian Lake]

Any primitive type with any nullability, yes

[agrosner]

Ah the issue I filed ! thank you color

[Ian Lake]

It was a bit too late for this release, but we are also looking at what we can do to make nested Serializables easier to use for the next release e.g., having a serializableType<YourType>() you can use

[agrosner]

Oh that would be great, you would then just pass that into the type map?

[Ian Lake]

That's the idea, yeah. Ideally with a quick fix lint

[Stylianos Gakis]

For now this is what I've done Andrew, after the discussion which took place here:
https://github.com/HedvigInsurance/android/blob/30cdff3adb19a591a3a5e84b476c49c107[…]om/hedvig/android/navigation/compose/JsonSerializableNavType.kt
Just encode everything as a string, relying on kotlinx.serialization since it can handle all scenarios like nested serializable types etc.

And for a destination like:

@Serializable
data class DateOfOccurrence(
  val dateOfOccurrence: LocalDate?,
  val someprimitiveWhichDoesNotRequireACustomMap: String,
  val maxDate: LocalDate,
  val info: Info,
) : Destination

I pass in

typeMapOf(
  listOf(
    typeOf<LocalDate?>(),
    typeOf<Info>(),
    typeOf<LocalDate>(),
    ... more custom types if required here
  )
)

And so far this seems to work for me.

[agrosner]

ohh interesting Stylianos - that would work nicely for small nested elements. larger ones obviously may not be ideal to turn them into strings.

[Stylianos Gakis]

Yeah I don't know how nested your destinations are, I would hope not so much that this string ends up being megabytes long right? 😅

[agrosner]

ha…our app has a lot of legacy things gone wrong, like large datamodel objects that contain large response java models with optional fields…without refactoring 120 fragment newinstance methods, ive resorted to just shoving the data into an intermediate state holder and pulling it out the other side when navigated in compose and rendered in onCreate. 😄

[Stylianos Gakis]

I regret asking ☠️