Hello hello! We are migrating to apollo 4 and we a...

# apollo-kotlin

[Marco Pierucci]

Hello hello! We are migrating to apollo 4 and we are seeing some issues with our tests ( involving data builders and fragment builders) 🧵

[Marco Pierucci]

val appointmentInfo = AppointmentInfoImpl.Data(KrakenFieldFakeResolver()) {
buildFieldUserAppointmentType {
id = "appointmentId"
notes = "test-notes"
assetProviderData = buildAssetProviderDataType {
assetProvider = ""
commsHubVariant = ""
}
}
}
val sut = appointmentInfo.assetProviderData?.assetProviderInfo()

Assert.assertEquals(null, sut)
This text suddenly stoped passing and for what we have inspected its because the values assigned on the blocks are not actually re values in the resulting appointmentINfo class.
After some debuggin we can see that the resulting values in buildFieldUserAppointmentType
are correct but the result of AppointmentInfoImpl.Data(KrakenFieldFakeResolver()) is ignoring the values and using defaults

[mbonnin]

Let me see if I can reproduce

[mbonnin]

so notes is not good up there?

[Marco Pierucci]

We are expecting test-notes

[Marco Pierucci]

right?

[mbonnin]

Yes, I would expect this as well

[mbonnin]

Is it still happening if you remove the KrakenFieldFakeResolver() ?

[John O'Reilly]

we get following in that case

Don't know how to instantiate leaf UUID
java.lang.IllegalStateException: Don't know how to instantiate leaf UUID
	at com.apollographql.apollo.api.DefaultFakeResolver.resolveLeaf(fakeResolver.kt:280)

[mbonnin]

Ok gotcha 👍
Looks like you’re not using the result of buildFieldUserAppointmentType , does that need to be set to some field?

[mbonnin]

Something like this?

val appointmentInfo = AppointmentInfoImpl.Data(KrakenFieldFakeResolver()) {
    userAppointment = buildFieldUserAppointmentType {
        id = "appointmentId"
        notes = "test-notes"
        // ...
    }
}

[John O'Reilly]

so just tried following and it passed

val appointmentInfo = AppointmentInfoImpl.Data(KrakenFieldFakeResolver()) {
//            buildFieldUserAppointmentType {
                id = "appointmentId"
                notes = "test-notes"
                assetProviderData = buildAssetProviderDataType {
                    assetProvider = ""
                    commsHubVariant = ""
                }
//            }
        }

[John O'Reilly]

buildFieldUserAppointmentType not needed any more it seems?

[mbonnin]

I’m curious how come it was need before actually, the buildFoo() return value is really supposed to be used 🤔

[John O'Reilly]

I think change in 4.0 in way that those blocks are applied?

[mbonnin]

Looks like it

[mbonnin]

I’ll dig

[mbonnin]

This doesn’t happen to be a public schema by any chance?

[Marco Pierucci]

public
    fun BuilderScope.buildFieldUserAppointmentType(block: FieldUserAppointmentTypeBuilder.() -> Unit):
    FieldUserAppointmentTypeMap {
  val builder = FieldUserAppointmentTypeBuilder(customScalarAdapters)
  builder.__typename = "FieldUserAppointmentType"
  builder.block()
  return builder.build()
}

this in 3.8.4

[John O'Reilly]

and this is in 4.0

public
    fun BuilderScope.buildFieldUserAppointmentType(block: FieldUserAppointmentTypeBuilder.() -> Unit):
    FieldUserAppointmentTypeMap =
    FieldUserAppointmentTypeBuilder(customScalarAdapters).apply(block).build()

[mbonnin]

Ok seems related to https://github.com/apollographql/apollo-kotlin/pull/4782

[mbonnin]

That’s a good callout, we should have included that in the migration guide.

[mbonnin]

For fragments, the top level buildFoo {} is not needed anymore, sorry I forgot it was like this in v3

[Marco Pierucci]

yep all makes sense now! thanks!

[mbonnin]

Migration guide PR here https://github.com/apollographql/apollo-kotlin/pull/6087

[mbonnin]

Also took this opportunity to add some docs for fragments, just realized we had none

[Marco Pierucci]

Ah yes! I was looking for it when trying to see if we screwed somethign with the migration and could not find it

[Marco Pierucci]

👏