Can androidx.graphics:graphics-shapes be used on d...

# compose-desktop

[Caleb Kiage]

Can androidx.graphics:graphics-shapes be used on desktop? I want to access the Morph type

[Ivan Matkov]

We don't have any extra adoption on Compose Multplatform/JB fork side, but as I can see it's published by Google with desktop support. So it should work I guess

[Caleb Kiage]

Thanks! I'll try it out

[Caleb Kiage]

It didn't work in the end 🥲 the toPath extension method doesn't exist on desktop 😔

[Ivan Matkov]

Path there is Android platform type. Nor skiko or compose shouldn't be in dependencies there. Also, as I see this function is about a few lines only, so I don't think that it should be a blocker to adopt this piece

[Ivan Matkov]

https://github.com/androidx/androidx/blob/androidx-main/graphics/graphics-shapes/s[…]c/androidMain/kotlin/androidx/graphics/shapes/Shapes.android.kt

[Caleb Kiage]

I think the asComposePath also needs to be moved to the common package as well. I'll try copy these functions when I get time

[Caleb Kiage]

It's in Android and desktop separately

[Ivan Matkov]

Yes, it's because its for different types

[Ivan Matkov]

No, it shouldn't be in common

[Caleb Kiage]

There should be an expect fun in common, no?

[Ivan Matkov]

To have this expect function, it should be expect typealias type. I don't think that public common typealias for type from skiko library is a good thing

[Ivan Matkov]

I know that we have something leaking to public, but Compose public API surface, especially common shouldn't expose any skiko things. It's implementation details

[Ivan Matkov]

For this particular case we need a function to direct transformation to Compose type from that shapes

[Caleb Kiage]

Mhhh. I'm still very new to compose apis. I thought it would work to make it common so people can copy and paste snippets from the android docs...that would be great DX

[Ivan Matkov]

It should work for Compose code, but NOT for platform types.

[Ivan Matkov]

android.graphics.Path is part of Android OS SDK, and it should not be in common

[Ivan Matkov]

androidx.compose.ui.graphics.Path is a part for Compose, and it should be in common

[Caleb Kiage]

Mhhh...makes sense. Then toPath is probably the wrong function to use. Probably something that converts to a composable directly would work?

[Caleb Kiage]

Like toComposePath?

[Caleb Kiage]

Then internally it converts to the composable for that platform

[Ivan Matkov]

compose shouldn't be in dependencies there

The problem here is that library is not aware of compose. And shouldn't be. And Compose is not aware of that library and shouldn't be.
I agree this function should exists, but not sure where exactly yet