A modern programming language that makes developers happier.

kotlinlang

Hello team,
I am considering making a small contribution to <https://github.com/JetBrains/kotlin/blob/master/compiler/build-tools/kotlin-build-tools-api/README.md|BuildToolsApi>. We are currently experimenting with integrating it into our build tool to simplify the integration of the incremental compiler. Following the <https://github.com/JetBrains/kotlin/blob/master/docs/contributing.md#contributing|contributing guidelines>, I wanted to reach out first about the changes I am proposing.
1. Add an option to pass a custom fallback Classloader in <https://github.com/JetBrains/kotlin/blob/f8232c95542812fe88b081beb494039e6dd4c67f/compiler/build-tools/kotlin-build-tools-api/src/main/kotlin/org/jetbrains/kotlin/buildtools/api/SharedApiClassesClassLoader.kt#L22|SharedApiClassesClassLoader>. We are using our own class loader which we require to be used if the name of the class does not start with allowedPackage. This change will be backward compatible thanks to default arguments.
2. Return null when mapping SourcesChanges.ToBeCalculated to ChangedFiles instead of ChangedFiles.Unknown() in <https://github.com/JetBrains/kotlin/blob/f8232c95542812fe88b081beb494039e6dd4c67f/compiler/build-tools/kotlin-build-tools-impl/src/main/kotlin/org/jetbrains/kotlin/buildtools/internal/icAdapters.kt#L18|icAdapters>, which causes the module to be rebuilt (there is TODO for changing the logic). If I am not mistaken, null will force the compiler to calculate changed files itself.
Since those are minor changes, I have not created Youtrack issues.
Let me know if you have any concerns.

FYI: Build Tools API is not yet a stable API and may change in any Kotlin release

Created <https://youtrack.jetbrains.com/issue/KT-70557|KT-70557>, <https://youtrack.jetbrains.com/issue/KT-70556|KT-70556>.