Or not... Release failed and I don't have time to ...
# ktfmtn
Nivaldo H Bondança
08/14/2024, 2:10 PMOr not... Release failed and I don't have time to look into this now and for the next couple of weeks.
I'll see if someone else from the team can take a look, but feel free to chime in in case you know what's up
https://github.com/facebook/ktfmt/actions/runs/10388724255/job/28765014936
😢 1
s
seb
08/15/2024, 7:27 AMUnfortunately I have zero Maven experience. If it were Gradle I could help...
c
christophsturm
08/20/2024, 10:05 AMI think its related to bumping the java version of ci to 17. reset it back to 11 and it will probably work again
christophsturm
08/20/2024, 10:07 AMthe root cause of the problem is that the publish workflow is not tested when it is changed so when it breaks its not noticed right away.
christophsturm
08/20/2024, 10:45 AMI made a pr that possibly fixes it https://github.com/facebook/ktfmt/pull/507
❤️ 1
g
gammax
08/20/2024, 1:42 PMgammax
08/20/2024, 1:42 PMversion is out
gammax
08/20/2024, 1:42 PM@christophsturm turns out 1.6.13 worked at the end of the day
c
christophsturm
08/20/2024, 1:43 PMwith jdk 17?
s
seb
08/20/2024, 1:57 PM@gammax the release notes are not mentioning the custom settings in the IJ profile, probably worth pointing it out as it's a pretty big change, relative to the plugin scope 🙂
g
gammax
08/20/2024, 4:19 PMOh true. That’s because they’re also missing in the CHANGELOG.md. Could you send a PR updating it and I’ll mirror it to the Releases page
s
seb
08/20/2024, 4:23 PM4 Views