I'm hitting what seems to be a regression in the D...
# eapi
ianbrandt
08/16/2024, 4:57 PMI'm hitting what seems to be a regression in the Dependency Analysis Gradle Plugin's ability to filter test source sets from its analysis when upgrading from Kotlin 2.0.10 to 2.0.20-RC or 2.0.20-RC2: https://github.com/autonomousapps/dependency-analysis-gradle-plugin/issues/1239. Did anything notable change with how the Kotlin Gradle Plugin handles source sets in 2.0.20?
youtrack 1
👍 1
✅ 1
ianbrandt
08/16/2024, 5:02 PMAn aside, this is all related to working around KT-63285. It keeps getting pushed to later Kotlin versions, so just a shameless plug for that issue. 😉
sweating 1
t
tapchicoma
08/19/2024, 1:06 PMdo you see this problem as well with
2.0.20-Beta2i
ianbrandt
08/19/2024, 4:15 PMAh, good question. I just tested it, and it does reproduce with 2.0.20-Beta2.
t
tapchicoma
08/19/2024, 4:20 PMthen could you also test with
2.0.20-Beta1tapchicoma
08/19/2024, 4:20 PMthis will allow to narrow commits range
i
ianbrandt
08/19/2024, 4:53 PMAha, it does not reproduce with 2.0.20-Beta1. In parallel I believe I've just come up with a shareable reproducer that demonstrates that. Standby.
ianbrandt
08/19/2024, 6:20 PMReproducer: https://github.com/sdkotlin/sd-kotlin-spring-talks/tree/f55c327ee46061982ceebdd745070cc78d5fa831. See the updated autonomousapps/dependency-analysis-gradle-plugin#1239 description for details.
t
tapchicoma
08/19/2024, 8:46 PMI don't see any relevant on the first sight commit between Beta1 and Beta2. Possibly it could be discovered by bisecting, but I don't have time to do it right now
i
ianbrandt
08/21/2024, 5:49 PMThank you for looking into it. Perhaps @tony will have some insights as the maintainer now that I have a reproducer posted to the issue for debugging.
I was blocked on upgrading to 2.0.0 and 2.0.10 by compiler bugs that have been fixed, so I was really hoping 2.0.20 was going to be the one. We rely on the Dependency Analysis Gradle Plugin heavily to keep our dependency declarations sane, so if this does turn out to be a 2.0.20 issue, we'd likely have to stick with 1.9.x yet again. Being at RC2 already, what sort of timeframe (if any) do we have before the release decision to determine whether this is a regression?
👀 1
t
tony
08/21/2024, 5:56 PMThanks for the reproducer! I would like to take a look, but can't make any promises on the timeline right now
👍 1
a
Anton Mefodichev
08/22/2024, 9:09 AMCreated a ticket:
https://youtrack.jetbrains.com/issue/KT-70871/Dependency-Analysis-KGP-ability-to-filter-test-source-sets-from-its-analysis-regression
thank you color 1
i
ianbrandt
08/22/2024, 4:00 PMRegarding 2.0.20 release timeframe, it looks like that's answered: https://github.com/JetBrains/kotlin/releases/tag/v2.0.20.
ianbrandt
10/15/2024, 4:19 PMI re-raised this in the Gradle channel, as 2.0.20 is no longer in EAP.
9 Views