Just want to catch attention of Google team to issue that breaks compiler plugins ir transformation after Compose compiler plugin processed. For my pov it is critical issue.
The link to issue: https://issuetracker.google.com/issues/365066530
s
shikasd
09/15/2024, 3:41 PM
It sounds like isSubclassOf check is a bit weird in the first place, since it just checks for symbol equality.
I will look into this more next week just in case we do something stupid
π 1
shikasd
09/16/2024, 12:52 PM
So I double checked and it mostly boils down to reference equality checks in
isSubclassOf
. You might want to compare these classes by fqName or something similar instead.
Compose compiler copies IR to update the @Composable function types, that involves copying classes and functions as well. There's an optimization that is a bit overdue to just update the types in place, but that should be done very carefully to avoid introducing any regressions.
p
PHondogo
09/16/2024, 2:29 PM
@shikasd@ΠΠ°Π²Π΅Π» ΠΡΠ½ΡΠ²ΡΠΊΠΈΠΉ what is the future of this issue?
Is it needed to be fixed on JetBrains or Google side?
s
shikasd
09/16/2024, 2:42 PM
technically I'd argue this is more of the Compose issue, but not sure this is easily fixable