what's the syntax for applying a plugin using version catalogs and build convention? Details in thre...

# gradle

[Francesc]

what's the syntax for applying a plugin using version catalogs and build convention? Details in thread.

[Francesc]

I have this in the toml file

[plugins]
com-android-compose-screenshot = { id = "com.android.compose.screenshot", version.ref = "com-android-compose-screenshot-version"}

and I'm trying to apply the plugin like so

class AndroidLibraryComposeConventionPlugin : Plugin<Project> {
    override fun apply(target: Project) {
        with(target) {
            pluginManager.apply("com.android.library")
            pluginManager.apply("kotlin-parcelize")
            
            // plugin applied here
            val plugin = catalog.findPlugin("com.android.compose.screenshot").get().get()
            pluginManager.apply(plugin.pluginId)
            val extension = extensions.getByType<LibraryExtension>()
            configureAndroidCompose(extension)
        }
    }
}

[Francesc]

the plugin is not resolved,

* What went wrong:
An exception occurred applying plugin request [id: 'weathersample.android.library.compose']
> Failed to apply plugin 'weathersample.android.library.compose'.
   > Plugin with id 'com.android.compose.screenshot' not found.

[ephemient]

that should work if [plugins] com-android-compose-screenshot is in the consumer project

[Francesc]

I'll check tomorrow, thanks

[Vampire]

If you would want to control the version in the plugin project, add a dependency on that other plugin in your plugins's build script

[Francesc]

I think I'm missing a dependency in the plugin's build.gradle file, I have these in there

dependencies {
    compileOnly(libs.com.android.tools.build.gradle)
    compileOnly(libs.org.jetbrains.kotlin.kotlin.gradle.plugin)
    compileOnly(libs.io.gitlab.arturbosch.detekt)
}

so I may need to add a dependency for the screenshot plugin as well?

[Francesc]

that didn't help, I've added

com-android-compose-screenshot-plugin = { module = "com.android.compose.screenshot:com.android.compose.screenshot.gradle.plugin", version.ref = "com-android-compose-screenshot-version" }

in the toml file and

dependencies {
    compileOnly(libs.com.android.tools.build.gradle)
    compileOnly(libs.org.jetbrains.kotlin.kotlin.gradle.plugin)
    compileOnly(libs.io.gitlab.arturbosch.detekt)
    compileOnly(libs.com.android.compose.screenshot.plugin)
}

in the build.gradle but still no dice

[ephemient]

to the plugin's toml or to the applying project's?

[Francesc]

there is only one toml file

[Francesc]

not sure I understand the question

[Vampire]

If you only add that plugin to compileOnly in your plugin build, that does not change anything.
You do not use any classes, but only apply by id, so compileOnly of course does not make any difference.

[Vampire]

And whether you have the plugin in the version catalog of the consumer build or not also does not make any difference

[Vampire]

A version catalog is just a catalog of things to pick from.
Having something there alone does not have any effect.

[Vampire]

That in your plugin you get the version catalog entry for that plugin and get the plugin id from that entry is technically identical to just hard-code the ID String.

[Vampire]

The only difference is, that the catalog could define a different ID

[Francesc]

well, the idea is to have the versioning in the toml

[Vampire]

But that does not bring the plugin onto the classpath so you cannot apply it

[Francesc]

ok, do you have any pointer on how to go about it?

[Vampire]

Sure, read my first response for example

[Vampire]

Sounds like you are anyway talking about convention plugins within one build and not a plugin that is used in multiple builds

[Vampire]

So just add an implementation dependency on the plugin to your plugin build and you are fine

[Francesc]

I did, but that didn't shed much light unfortunately, it probably assumes some knowledge on my part I don't have

[Vampire]

You did not

[Vampire]

At least not in what you showed

[Francesc]

I was replying to your "read my first comment" message

[Vampire]

Ah, sorry, got you wrong

[Vampire]

But well, I just explained it again in different words

[Francesc]

so change compileOnly to implementation ?

[Vampire]

And if you do not understand something that someone trying to help you says, it could help to ask for clarification instead of just discarding. ;-)

[Francesc]

well, the message came while I was sound asleep

[Vampire]

Dare you ever sleeping!

[Francesc]

that seems to have worked, thanks!

[Vampire]

😄