A modern programming language that makes developers happier.

kotlinlang

Looking at some Compose compiler <https://github.com/JetBrains/kotlin/blob/master/plugins/compose/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/k2/ComposableCallChecker.kt#L113|code here>, I see they’re doing some checks against `FirAnonymousFunction#psi` …I’m wondering if there’s a way to do an equivalent check without using `.psi`(or some other way to get around the fact that `PsiElement` is shaded and therefore needs different artifacts for Gradle vs the IDE)

If I understand correctly, this particular check is needed to distinguish lambda (`{ x -&gt; ...}`) from anonymous function (`fun (x) {...}`)
This can be done using plain fir by checking `firAnonymousFunction.isLambda`

That’s what I was guessing. I’m not sure why compose does it like that :sweat_smile:

(not being able to touch `PsiElement` is very annoying though)

> I’m not sure why compose does it like that
Probably they just copied part of the K1 implementation during K2 prototyping and it left here since then

> not being able to touch `PsiElement` is very annoying though
You can get used to it
I always considered PSI as terrible monstrosity, so it was so nice finally be able to operate something more useful

True, the only other place i’ve encountered needing it is for something like `val MY_ERROR by error0&lt;PsiElement&gt;()`

Yeah, and this place is needed only to some verification on IDE side
For IDE it's nice to know that some diagnostic might be reported only on specific `KtElement` (e.g. to avoid obvious casts)

my workaround was to make my own copy of `error0` and steal the `psiType` class from some built-in error :sweat_smile::
```private fun error0(strategy: AbstractSourceElementPositioningStrategy = SourceElementPositioningStrategies.DEFAULT) =
    DiagnosticFactory0DelegateProvider(
        Severity.ERROR,
        strategy,
        FirErrors.OTHER_ERROR.psiType,
    )```

In the compiler there are still few places, which have specific implementation for PSI (and a separate for LT), but they all are in syntax checkers, which really care about the original syntax tree
They could be written once for LT (as PSI is built on top of it), but writing the special PSI-based code is more effective

Do I understand correctly that you needed because of shaded/unshaded version of `PsiElement` class?
You can just use `KtElement` instead of `PsiElement`. It is located in `org.jetbrains.kotlin` package, so it isn't affected by shading

&gt;  Do I understand correctly that you needed because of shaded/unshaded version of `PsiElement` class?

Let me try that, that’d be great. I’ve seen a variety of hacks for this but not that solution. lol

e.g. <https://github.com/TadeasKriz/K2PluginBase/blob/main/kotlin-plugin/src/main/kotlin/com/tadeaskriz/example/ExamplePluginErrors.kt#L8>

that works perfectly, thank you! :slightly_smiling_face:

Probably I need to update plugin-sandbox and plugin-template with it

:wave: Came across this but `KtElement` doesn’t seem to be working for me—still seeing IDE errors when trying to trigger one of my diagnostics. Is there an example usage I can look at?