Thoughts on this extension method to java.util.Que...

# codereview

[Daniel Pitts]

Thoughts on this extension method to java.util.Queue?

private inline fun <T : Any> Queue<T>.drain(callback: (T) -> Unit) {
   while (true) poll()?.also(callback) ?: break
}

[ephemient]

https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/concurrent/BlockingQueue.html#drainTo(java.util.Collection)

[Daniel Pitts]

Yes, I’m not copying the data, I’m processing it in place.

[Daniel Pitts]

I realized what I really need for my use case is a MPSC queue.

[Arjan van Wieringen]

Maybe take a look at Channels

[Daniel Pitts]

This is not in a suspend context.

[Klitos Kyriacou]

You can use forEach instead of inventing your own.

[Daniel Pitts]

You do understand poll() has side effects right?

[Klitos Kyriacou]

Ah, of course, my mistake.

[Daniel Pitts]

Sorry my reply was a harsh. I could have said that better.