Would it be possible to get an update on <https://...
# dokka
s
Would it be possible to get an update on https://github.com/Kotlin/dokka/pull/3746? I'd love to see it merged before the 2.0 plugin is released, is there any possibility of that happening?
o
Hey! thanks for pinging, but it will be not possible to do it 2.0 scope Soon, some HTML changes which are already properly tested will be merged in master, and so it would take some time to test those changes again But still, I think that some of changes could be a nice addition. I'm still very sceptic about adding support for additional languages highlighting so I think it would be nice to start without them Could you update (or create new) PR with removing changes with all those additional languages? It would also help to speed-up review if you will provide screenshots with before and after with description of what is changed Thank you!
s
I can rebase it against the
ktl-1631-toc
branch to verify it works with the latest changes I'll also split the PR into two: 1. any of the more "core" stuff ◦ all of the code changes ◦ all of the css changes ◦ the languages included in this PR will consist of (note: "removed" uses for previous languages that were removed. "added" used for new languages. all others existed previously and are unchanged. dependent languages also marked in square brackets to explain some languages): ▪︎ css (removed) ▪︎ clike [dependency for gradle, groovy, java, kotlin] ▪︎ diff (added) ▪︎ gradle (added) ▪︎ groovy (added) ▪︎ java [dependency for javadoc] ▪︎ javadoc ▪︎ javadoclike [dependency for javadoc] ▪︎ javascript (removed) ▪︎ javastacktrace (added) ▪︎ kotlin ▪︎ markup [dependency for javadoc] 2. any additional non-"core" languages that would be "nice to have"s how does that sound?
o
or are there any others
there will be some small fixes, but yes, the most of the changes are there 1. looks more or less fine, but let's leave already available languages there (e.g css and javascript) as to not break existing users. 2. let's try. May be there is some dynamic way of loading those languages on user side? So that there will be no need for users to always bundle all those languages, but only when they are used? I'm still very sceptic regarding the need for them, as I haven't seen a lot of features requests for them. Probably it will be better to do this case-by-case, and not add all at once - will see