On a side note, I was wondering if someone also co...

# koin

[Helio]

On a side note, I was wondering if someone also could shed some light regarding the correct approach to overcome the deprecation of checkModules.

I was trying to following the documentation and I noticed that replacing the old validation checkModules with the new mechanism verify() it fails with the error: 🧵

[Helio]

* ----- > Missing definition for '[field:'engine' - type:'io.ktor.client.engine.HttpClientEngine']' in definition '[Singleton: 'io.ktor.client.HttpClient',qualifier:myHttpClient]'.
- Fix your Koin configuration -
1- add missing definition for type 'io.ktor.client.engine.HttpClientEngine'. like: singleOf(::io.ktor.client.engine.HttpClientEngine)
or
2- else define injection for 'io.ktor.client.HttpClient' with:
module.verify(
    injections = injectedParameters(
        definition<io.ktor.client.HttpClient>(io.ktor.client.engine.HttpClientEngine::class)
    )

)
Old Validation

@Test
    fun checkAllModules() = checkModules {
        modules(
            httpClientModule,
            redisModule,
            serviceModule,
            useCaseModule
        )

New Validation

@Test
    fun checkAllModules() {
        module {
            includes(
                httpClientModule,
                redisModule,
                serviceModule,
                useCaseModule
            )
        }.verify()
    }

Example of testing..cpp

[Olivier Patry]

I admit, I just blindly followed the suggestion of the error without understanding anything clearly…

@Test
fun `verify network module`() {
    networkModule.verify(
        injections = injectedParameters(
            definition<HttpClient>(HttpClientEngine::class, HttpClientConfig::class),
        )
    )
}

I'm not sure this was the best thing to do or if it just hides error…

At runtime my dependency graph is perfectly fine, but the test was failing 🤷

[Helio]

Thanks so much for jumping in Oliver. I actually tried fixing the resolution for those errors as well. However, it suggests adding

injections = injectedParameters(
                definition<HttpClient>(io.ktor.client.engine.HttpClientEngine::class),
            )

Then if I re-run, it asks to add

injections = injectedParameters(
                definition<HttpClient>(io.ktor.client.HttpClientConfig::class),
            )

Then, after re-run asks me to re-add the first one again (which seems to be overridden). That's why I'm super confused

[Helio]

I'll double-check

[Helio]

@Test
    fun checkAllModules() {
        module {
            includes(
                httpClientModule,
                redisModule,
                serviceModule,
                useCaseModule
            )
        }.verify(
            injections = injectedParameters(
                definition<HttpClient>(HttpClientEngine::class, HttpClientConfig::class),
                definition<TokenatorRedisClient>(io.lettuce.core.RedisClient::class)
            )
        )
    }

This seems to have fixed the issue indeed. I reckon I don't understand this much. 🤦🏽

[Olivier Patry]

Is it the same or another?
The first time, I had HttpClientEngine::class, the second time once added it, I then had HttpClientConfig::class, leading to add both classes to the definition call.

[Helio]

I think the problem I had before was that I was injecting them separetly, like that:

This is wrong

injections = injectedParameters(
                definition<HttpClient>(io.ktor.client.engine.HttpClientEngine::class),
                definition<HttpClient>(io.ktor.client.HttpClientConfig::class),
            )

[Alexandru Caraus]

I've got the same issue, somehow verify picks up the wrong constructor

[Alexandru Caraus]

https://github.com/InsertKoinIO/koin/issues/2029

[Alexandru Caraus]

+ the issue so it has higher prio

[arnaud.giuliani]

will look at it 👍