trying to update from kotlin-inject-anvil 0.0.5 to...

# kotlin-inject

[Josh Feinberg]

trying to update from kotlin-inject-anvil 0.0.5 to 0.1.0 and having an issue. i have a reproducible sample but i'm not sure if its just an issue with my coding or something broken in kotlin-inject or kotlin-inject-anvil

[Josh Feinberg]

you can see if you run ./gradlew build you get this error

> Task :shared:compileKotlinJvm FAILED
e: kiaerror/shared/src/commonMain/kotlin/com/example/kiaerror/AppComponent.kt:13:5 Unresolved reference 'AppComponentMerged'.

> Task :shared:verifyReleaseResources
> Task :shared:kspReleaseKotlinAndroid
> Task :shared:kspDebugKotlinAndroid

> Task :shared:compileDebugKotlinAndroid FAILED
e: kiaerror/shared/src/commonMain/kotlin/com/example/kiaerror/AppComponent.kt:13:5 Unresolved reference 'AppComponentMerged'.

> Task :shared:compileReleaseKotlinAndroid FAILED
e: kiaerror/shared/src/commonMain/kotlin/com/example/kiaerror/AppComponent.kt:13:5 Unresolved reference 'AppComponentMerged'.

FAILURE: Build completed with 3 failures.

kiaerror.zip

[Josh Feinberg]

i put in the example with the expect interface AppComponentMerged2 as that is how i'm fixing this in 0.0.5 however in 0.1.0 it is an error not to directly implement that interface

[ksp] kiaerror/shared/src/commonMain/kotlin/com/example/kiaerror/AppComponent.kt:11: AppComponent is annotated with @MergeComponent and @Component. It's required to add AppComponentMerged as super type to AppComponent. If you don't want to add the super manually, then you must remove the @Component annotation.

[Josh Feinberg]

happy to file a bug on whichever project may be the problem, or could just be that i'm doing this wrong here

[eygraber]

Maybe related to https://github.com/amzn/kotlin-inject-anvil/pull/61

[Josh Feinberg]

yes, that is the error. i'm wondering what i'm doing wrong here though cause if i don't extend AppComponentMerged I get that compile error but if I do my app won't compile

[eygraber]

I can't download the zip now, so can you send what your AppComponent looks like

[Josh Feinberg]

@AppScope
@Component
@MergeComponent(AppScope::class)
internal abstract class AppComponent(
    @Component val clientComponent: ClientComponent,
) : AppComponentMerged

[Josh Feinberg]

@NetworkScope
@Component
abstract class ClientComponent {
    @NetworkScope
    @Provides
    fun provideNetworkScopeObject(): NetworkScopeObject {
        return NetworkScopeObject()
    }
}

both the *Scope classes are annotations with the @Scope annotation

[eygraber]

I believe in 0.1.0 you're supposed to remove @Component and not extend AppComponentMerged. If you remove both of those do you still get an error?

[Josh Feinberg]

[ksp] kiaerror/shared/src/commonMain/kotlin/com/example/kiaerror/AppComponent.kt:10: Contributed component interfaces must be public.

so i can't have internal components anymore i guess?

[eygraber]

Yeah I just hit that as well 🙁

[Josh Feinberg]

though it also seems to have an issue even if i remove internal

@AppScope
@MergeComponent(AppScope::class)
abstract class AppComponent(
    @Component val clientComponent: ClientComponent,
) {
    abstract val networkScopeObject: NetworkScopeObject
}

that fails to find my NetworkScopeObject despite ClientComponent being a child component

[eygraber]

Looks like we're headed down the same road 😅

I was able to get it to work using ContributesSubcomponent

[eygraber]

Not sure if this is a bug or WAI... @ralf?

[eygraber]

Is ClientComponent also a MergeComponent?

[Josh Feinberg]

not in my use-case

[eygraber]

So just a regular @Component?

[ralf]

so i can’t have internal components anymore i guess?

No, because in 99% of the cases this is the wrong thing to do.

[ralf]

I have a hard time following the issue. I suggest to file a ticket, but please don’t attach a .zip file and create a repo on Github instead.

[Josh Feinberg]

https://github.com/amzn/kotlin-inject-anvil/issues/76 done

[ralf]

Thanks, I responded on Github. It’s a bug.