I’m trying out `NavigationSuiteScaffold` … by defa...

# compose

[alexhelder]

I’m trying out NavigationSuiteScaffold … by default, it still puts the nav items on the bottom when device is in landscape for ‘phone’ size devices, i would think if the W > H it would go to a rail. I can override it … but might create more bugs

[Pablichjenkov]

I think it is worth opening an issue

[Michael Krussel]

How tall of devices are you testing on. The threshold for medium is 600 dp.

[Pablichjenkov]

It most likely rely on the WindowSizeClass, and the way this API devices computes the values is subject to this error. I have experienced it before. That's what I think that API should consider portrait and landscape too

[Pablichjenkov]

That's exactly the issue, some phone devices in landscape meet that threshold

[Michael Krussel]

The height class should play into whether you display a bottom navigation or a side.

Not sure why they go with a navigation bar if the height is compact.

• Navigation bar if the width or height is compact or if the device is in tabletop posture

• Navigation rail for everything else

Makes little sense, but most phones in landscape will have either width or height compact.

[alexhelder]

It is a Resizable emulator (1080 x 2400) 420 dpi, so seems like correct behavior (but makes little sense as you said). Same behavior on other emulators / phones though. Ok thanks.

[Ian Lake]

Someone just recently filed an issue about phones in landscape that seems similar: https://issuetracker.google.com/issues/378726489