Hey, Can anyone help me with stackoverflow error i...

# squarelibraries

[Himanshu]

Hey, Can anyone help me with stackoverflow error in loadOnce method in Zipline

suspend fun startReturning(context: Context): LoadResult {
        val ziplineLoader = ZiplineLoader (
            ziplineDispatcher,
            ManifestVerifier.NO_SIGNATURE_CHECKS, okHttpClient.asZiplineHttpClient() ).withCache(
            ZiplineCache(context, FileSystem.SYSTEM, context.cacheDir.toOkioPath(), 10*1024*1024)
        )
        val zipline = startGreetingZiplineReturning(
            ziplineLoader = ziplineLoader,
            manifestUrl = "<http://10.0.2.2:8080/manifest.zipline.json>"
        )
        return zipline
    }

    private suspend fun startGreetingZiplineReturning(
        ziplineLoader: ZiplineLoader,
        manifestUrl: String
    ): LoadResult {


        return ziplineLoader.loadOnce("<app-name>",
            DefaultFreshnessCheckerNotFresh, manifestUrl, initializer = { zipline: Zipline ->
            }
        )
    }

this is called as

suspend fun invokeZiplineForResource(context: Context): ResourceService?{
        var resourceService : ResourceService? = null
        withContext(ziplineDispatcher) {
            try {
                val result = startReturning(context)
                resourceService = if (result is LoadResult.Success) {
                    result.zipline.take<ResourceService>("ResourceService")
                } else {
                    null
                }
            } catch (e: Exception) {
                e.printStackTrace()
            } finally {
                Log.e("zipline", resourceService.toString())
            }
        }
        return resourceService
    }

[jessewilson]

We’ve got fixes for this in Redwood that might fit you here. In Redwood we configure the threads that use Zipline to have larger stacks, because QuickJS likes big stacks

[jessewilson]

https://github.com/cashapp/redwood/blob/trunk/redwood-treehouse-host/src/androidMain/kotlin/app/cash/redwood/treehouse/AndroidTreehouseDispatchers.kt#L33

[jessewilson]

https://github.com/cashapp/redwood/blob/trunk/redwood-treehouse-host/src/iosMain/kotlin/app/cash/redwood/treehouse/IosTreehouseDispatchers.kt#L37

[Himanshu]

I am using the same size

[jessewilson]

Hmmm … does doubling it fix the problem?

[Himanshu]

I tried with 16

[jessewilson]

Ie. is this a problem with the algorithm or with the fixed limit?

[jessewilson]

Try 64?

[jessewilson]

I just wanna know if it’ll complete if the stack size is sufficient

[jessewilson]

Once you figure that out, you can go back to a smaller stack size by making the program slightly different

[Himanshu]

Trying now

[jessewilson]

Typically by finding calls that are done directly and replacing them with launches

[Himanshu]

Can withContext(ziplineDispatcher) be the issue instead of launching?

[jessewilson]

No, I was thinking specifically about launching in guest code

[Himanshu]

Failed with 64 too😢

[jessewilson]

It’s a QuickJS stack overflow?

[Himanshu]

yes

[jessewilson]

Can you try to print the stack before it crashes? Perhaps with the same strategy as the sampling profiler?

[Himanshu]

will try

[jessewilson]

QuickJs.interruptHandler = …

[jessewilson]

override fun poll(): Boolean {
    val stack = quickJs.evaluate("new Error().stack") as String
    println(stack)
    return false
  }

[jessewilson]

That might tell you what the heck is happening when you’re using 64 MiB of stack

[Himanshu]

thanks

[Himanshu]

Hey @jessewilson, I have been trying to find how to set a quickJs instance to zipline. Did not find any way to set a quickJS instance to zipline. Can you please help me here too

[jessewilson]

It’s on the host API only

[Himanshu]

Didn't get that 🙂

[Himanshu]

The issue is related to kotlinx serialization json, the error got fixed on removing json elements from the server side and error changed to ClassCastException on making version same for kotlinx serialization core and kotlinx serialization json modules

[jessewilson]

Yay

[Himanshu]

Still have to figure out ClassCastException

[Himanshu]

Assuming that the Zipline doesn't work well when the implementation includes Json. Abandoning using Json in my Service Implementation.

[jessewilson]

interesting