I really wonder how things are working. I have a m...

# compose

[Eugen Martynov]

I really wonder how things are working. I have a module that has compose library dependency but it was forgotten to enable plugin and set feature flag for AGP. Everything compiled but runtime was failing because module function was not updated to add compose related parameters. So I wonder how consumer of this function compiled without error, does it mean that compose compiler plugin modifies bytecode after?

[ephemient]

it doesn't modify the bytecode after, it does completely change what bytecode is generated though

[ephemient]

simplified,

@Composable foo()
@Composable bar() { foo() }

the frontend sees that @Composdable foo(): Unit can call @Composable bar(): Unit
then the codegen produces something equivalent to

fun foo(composer: Composer, changed: Int) { bar(composer, ...) }

due to the Compose compiler plugin modifying how @Composable functions work

[Eugen Martynov]

Then I'm not sure how kotlin compiler works. The consumer module compilation should see that bytecode doesn't have compose added params.

[ephemient]

frontend isn't looking at the other module's bytecode to see that the declaration has or hasn't been processed by the compiler plugin and backend doesn't check. it just emits a call to the expected function signature

[Eugen Martynov]

I'm not sure about that. Since why would I have a compile error if the library doesn't have such a function. And it will happen in IDE or if I compile from command line

[ephemient]

you have a compile error when the frontend can'tresolve to something that doesn't exist. but, the model that it uses is one that contains @Composable fun bar() based on the Kotlin metadata which does exist, not based off of the presence or absence of bar:(Landroidx/compose/runtime/Composer;I)V in the bytecode

[ephemient]

IDE or command line, same thing

[Eugen Martynov]

Also not clear, because I remember compile time error when parameter not found or parameter type changed