Hello! I just ran into the "`ApolloStore#writeAndPublish` overwrites cache entries when using fragments" issue in Apollo 2. I saw that this is fixed in Apollo 3, but upgrading is not feasible at this time. So I came up with a hacky solution. Would something like this be accepted in the project, on the

release-2.x

branch? I didn't find a good way to write tests for my changes, but I wrote this pseudo-test to prove that the implementation is correct. Cheers!

Hi! I think we'd happily accept a PR 🙂 As I'm not hyper familiar with the v2 codebase, it's hard for me to understand if there's a risk of regression / impacts on something else. I guess if all the tests pass, that's already good indication of ✅

Hi, Benoit! Thanks for you answer! Do you think that it would make sense to also include that pseudo-test which requires making a couple of private methods internal?

No strong preference, but I think we'd rather keep them as private. Would it be possible to import the test mentioned in the issue as an integration test instead (in

apollo-integration

)?

Opened here: https://github.com/apollographql/apollo-kotlin/pull/4358 🙂

There's a couple of fixes in. Let me double check that we're not missing anything and I'll trigger the release

Hi, @mbonnin! I am really sorry to bother you, but do you have any updates on a V2 release? 🙏 I would normally not ask something like this, but I've been blocked on two tasks at work since uncovering this bug 😭

No worries at all, this one is on me. We have a 3.x release with

@defer

pending too and I wanted to make both at the same time but that 3.x release is lagging

no worries, thank you so much!!!! good luck with the 3.x release!

Thank you!!! So fast!

Yup, the GitHub and Sonatype gods were mercyful today 😄