https://kotlinlang.org logo
#apollo-kotlin
Title
# apollo-kotlin
e

Eduard Boloș

08/25/2022, 10:58 AM
Hello! I just ran into the "`ApolloStore#writeAndPublish` overwrites cache entries when using fragments" issue in Apollo 2. I saw that this is fixed in Apollo 3, but upgrading is not feasible at this time. So I came up with a hacky solution. Would something like this be accepted in the project, on the
release-2.x
branch? I didn't find a good way to write tests for my changes, but I wrote this pseudo-test to prove that the implementation is correct. Cheers!
b

bod

08/25/2022, 1:15 PM
Hi! I think we'd happily accept a PR 🙂 As I'm not hyper familiar with the v2 codebase, it's hard for me to understand if there's a risk of regression / impacts on something else. I guess if all the tests pass, that's already good indication of
e

Eduard Boloș

08/25/2022, 1:16 PM
Hi, Benoit! Thanks for you answer! Do you think that it would make sense to also include that pseudo-test which requires making a couple of private methods internal?
b

bod

08/25/2022, 1:19 PM
No strong preference, but I think we'd rather keep them as private. Would it be possible to import the test mentioned in the issue as an integration test instead (in
apollo-integration
)?
e

Eduard Boloș

08/25/2022, 2:59 PM
m

mbonnin

08/30/2022, 6:33 PM
There's a couple of fixes in. Let me double check that we're not missing anything and I'll trigger the release
e

Eduard Boloș

09/07/2022, 2:53 PM
Hi, @mbonnin! I am really sorry to bother you, but do you have any updates on a V2 release? 🙏 I would normally not ask something like this, but I've been blocked on two tasks at work since uncovering this bug 😭
m

mbonnin

09/07/2022, 3:08 PM
No worries at all, this one is on me. We have a 3.x release with
@defer
pending too and I wanted to make both at the same time but that 3.x release is lagging
Triggering the 2.x build right now (for real this time)
Sorry about the inconvenience
e

Eduard Boloș

09/07/2022, 3:08 PM
no worries, thank you so much!!!! good luck with the 3.x release!
It typically takes ~1h for the build to finish + push the "release" button + the time to propagate to maven central. Should be live in a couple of hours
e

Eduard Boloș

09/07/2022, 4:12 PM
Thank you!!! So fast!
m

mbonnin

09/07/2022, 4:13 PM
Yup, the GitHub and Sonatype gods were mercyful today 😄
8 Views