Hi. While receiving multipart uploads, do I need t...

# ktor

[Jakub Gwóźdź]

Hi. While receiving multipart uploads, do I need to close any of the resources?
Basically my routing looks like this:

post("/fileimport") {
                val multipartData = call.receiveMultipart()
                val parts = multipartData.readAllParts()
                    .filterIsInstance<PartData.FileItem>()
                    .mapIndexed { index, item ->
                        UploadedContent(
                            name = item.name ?: "unnamed$index",
                            filename = item.originalFileName ?: "unnamed$index",
                            contentType = item.contentType,
                            bytes = item.provider.invoke().readBytes()
                        )
                    }
                doSomething(parts)
                call.respond("OK")
            }

so the questions is - do I need to somehow close resources created by call.receiveMultipart() or item.provider.invoke().readBytes()?

[August Lilleaas]

none of them seem to implement Closeable, so I guess the answer is no 🙂

[Jakub Gwóźdź]

there is this .dispose() method but I’m not sure if this is something to be called manually, or it’s internal mechanism

[Jakub Gwóźdź]

and provider.invoke() returns closeable, so I’m thinking

bytes = item.provider.invoke().use { it.readBytes() }

🙂

[Aleksei Tirman [JB]]

You should call the dispose() method on the binary and file items to free associated resources.

[Aleksei Tirman [JB]]

https://stackoverflow.com/a/72438289/13963150

[Jakub Gwóźdź]

Thanks!