Hey, is room KSP meant to be faster than with KAPT...
# roomj
juliocbcotta
09/01/2022, 9:12 AMHey, is room KSP meant to be faster than with KAPT?
I ran some benchmarks with gradle profiler using the latest version of room (2.5.0-alpha03) and the results are inconclusive for me...
juliocbcotta
09/02/2022, 2:28 PM@yigit maybe you know whom I should be asking for this info?
juliocbcotta
09/02/2022, 7:42 PMThanks for the reply.
I ran two benchmarks, just compiling and compiling with a abi change in a sample app ( with 3 modules and each module with a room db). In all cases the benchmark failed to determine if ksp improved anything over kapt. In both cases I would expect gains from the due the lack of stubs, but using a pared t-test with 95% percentile it seems that there is no compilation time improvements.
Maybe my sample was too simple? Would you be able to share a link to your benchmark code?
juliocbcotta
09/07/2022, 8:08 AMSorry to insist, but I am confident that or we have a regression with ksp or room ksp performance. Should I open an issue ?
y
yigit
09/07/2022, 1:31 PMApologies i was ooo, no need to be sorry to insist, this is great feedback.
A bug report with a link to the benchmark would be great. Also, make sure the abi change is actually invalidating kapt (the thing i mentioned above).
Also, wrt stubs, that task is incremental as well so it is never certain that KSP will always beat kapt. KSP 's impact is more clear for clean compilation.
Nevertheless, it would be great to see a bug report with a link to benchmark so we can reproduce.
j
juliocbcotta
09/07/2022, 1:33 PMOk, Thank you. I will try to create the issue soon.
juliocbcotta
10/03/2022, 2:57 PM27 Views