https://kotlinlang.org logo
Join Slack
Powered by
Is there a specific reason Koin now requires `"org...
# koin
m
Is there a specific reason Koin now requires 
"org.gradle.jvm.version": 11
? (Edit: looks like it's for 
koin-test-junit5
and 
koin-ktor
but not for 
koin-core
)
a
Hi Martin, 🤔 let me look at that
what version?
m
3.2.1 IIRC
a
ok, need to see from where the java compile version is leaked
perhaps, as I removed some of them, its by default in java 11?
m
I believe it comes from the JDK that was used to compile the lib
This has happen before in KotlinPoet and other libs
a
then, we need to be explicit in terms of jdk
m
Exactly
a
also android parts needs java 11
m
also android parts needs java 11
Oh, that's interesting, I would expect Android to be like stuck on Java8 forever
a
Oh, that’s interesting, I would expect Android to be like stuck on Java8 forever
for Compose it’s java 11
m
Ah, I see yes, for the build JDK, but not the runtime JRE
I'm happy to send a PR if you want
a
ho yeah 🙂
you’re welcome 🙂
m
👍 Will try to send something later today
PS: would you be open to moving the build scripts to Kotlin?
(
build.gradle.kts
)
a
yeah, I’m open but didi,’t had time to clean up it
m
not saying I'll do it for this PR because it's a larger effort but I personally like build.gradle.kts, it's making things more maintainable/discoverable
maybe as a follow up PR
a
yeah, or something we can do together 👍
don’t you have problems in kts files ?
I thought to have regularly red lines everywhere 😄
m
No problem anymore, it's pretty smooth these days
There's a chicken and egg issue where it's all red until you can make your first Gradle sync but once you reach that point, it's all happiness
There's a small price to pay because Kotlin compilation is still slower than Groovy but it's worth it IMO
a
👍
m
a
top 👍
5 Views
Open in Slack
PreviousNext
Powered by