Bradleycorn
12/19/2024, 3:20 PMFrançois
12/19/2024, 5:07 PMkpgalligan
12/19/2024, 6:53 PMFrançois
12/19/2024, 7:19 PMFrançois
12/19/2024, 7:21 PMkpgalligan
12/19/2024, 7:26 PMkpgalligan
12/19/2024, 7:27 PMkpgalligan
12/19/2024, 7:29 PMFrançois
12/19/2024, 7:33 PMBradleycorn
12/19/2024, 7:34 PMI'd always recommend having the db in a module and not exporting that module explicitly,Yeah, i always put database (and other long term storage) stuff and network stuff into their own modules, and don't export those. They remain internal to the kotlin library. You mentioned Ktor stuff getting "leaked" into the exported api ... I have run into that before as well.
François
12/19/2024, 7:35 PMkpgalligan
12/19/2024, 7:46 PMGreat to hear that. I guess we can’t control the visibility of the generated class?It's been discussed. I'm all for it, in theory, but it's never been a huge priority for me, simply because we use the structural approach of hiding those with modules.
Jacob Ras
12/20/2024, 9:23 AMFrançois
12/20/2024, 9:56 AMJacob Ras
12/20/2024, 12:14 PMBradleycorn
12/20/2024, 5:44 PMembedAndSignAppleFrameworkForXcode
gradle task), something doesn't work right and some files that xcode uses for indexing don't wind up in the right place. The work around is to add some additional code to that build phase script to "manually" copy the appropriate files to the right place. It looks like this:
cd "$SRCROOT/.."
./gradlew :shared:embedAndSignAppleFrameworkForXcode
DERIVED_DATA_DIR=$(echo "${TARGET_BUILD_DIR}" | awk -F'/Build/' '{print $1}')
INDEXER_DATA_DIR=${DERIVED_DATA_DIR}/Index.noindex/Build/Products/Debug-$PLATFORM_NAME
mkdir -p $INDEXER_DATA_DIR
cp -R shared/build/xcode-frameworks/$CONFIGURATION/$SDK_NAME/* ${INDEXER_DATA_DIR}
Here's a link to the old thread:
https://kotlinlang.slack.com/archives/C3PQML5NU/p1709811731499599