Which one do you prefer? :one: ```suspend fun <...

# codingconventions

[George Z]

Which one do you prefer?
1️⃣

suspend fun <T : Any> handleApi(execute: suspend () -> T): Resource<T> {
    return try {
        val response = execute()
        Resource.Success(response)
    } catch (e: Exception) {
        Resource.Error(
            when (e) {
                is IOException -> ErrorType.Network
                is HttpException -> mapApiError(e.code())
                is SerializationException -> ErrorType.Serialization
                else -> ErrorType.Unknown
            }
        )
    }
}

2️⃣

suspend fun <T : Any> handleApi(execute: suspend () -> T): Resource<T> {
    return try {
        val response = execute()
        Resource.Success(response)
    } catch (e: IOException) {
        Resource.Error(ErrorType.Network)
    } catch (e: HttpException) {
        Resource.Error(mapApiError(e.code()))
    } catch (e: SerializationException) {
        Resource.Error(ErrorType.Serialization)
    } catch (e: Exception) {
        Resource.Error(ErrorType.Unknown)
    }
}

[LeoColman]

I'd probably go for an alternate route on creating the Resource.Error;

catch (e: Exception) { 
  return Resource.Error(e)
}

and handle the exception type inside Resource.Error()

fun Resource.Error(e: Exception) {
  when(e) {
    is IOException -> Resource.Error(ErrorTypeNetwork)
  }
}

Would take the code to a different place instead of inside a catch block and will help with testing

[George Z]

something like this, right?

suspend fun <T : Any> handleApi(execute: suspend () -> T): Resource<T> {
    return try {
        val response = execute()
        Resource.Success(response)
    } catch (e: Exception) {
        Resource.Error(mapException(e))
    }
}

private fun mapException(exception: Exception): ErrorType {
    return when (exception) {
        is IOException -> ErrorType.Network
        is HttpException -> mapApiError(exception.code())
        is SerializationException -> ErrorType.Serialization
        else -> ErrorType.Unknown
    }
}

[Robert Williams]

Be very careful here - Exceptions are internally used for coroutine cancellation and catching these will break things in surprising and confusing ways. If you really need to catch all exceptions, make sure you read this first: https://betterprogramming.pub/the-silent-killer-thats-crashing-your-coroutines-9171d1e8f79b