A modern programming language that makes developers happier.

kotlinlang

*Need Help with a Skiko Issue (Incorrect Text Width) _Wasm/Js and Native Environments_*
In the Skiko project, I’ve encountered a potential issue with text measurement and encoding. Here's the context:
• In `Skiko Native.native.kt`, `Native.js.kt`, and `Native.wasm.kt`, there is an `actual` implementation of the `expect` function `toInterOp` declared in `Native.kt` (CommonMain).
• The function uses `convertToZeroTerminatedString()` to convert a `String` to a `ByteArray`, encoding it to UTF-8.
However, in `NativeJsMain/Cpp/Font.cc`, the `measureText` function is configured as follows:
```SKIKO_EXPORT KFloat org_jetbrains_skia_Font__1nMeasureTextWidth
  (KNativePointer ptr, char* str, KInt len, KNativePointer paintPtr) {
    SkFont* instance = reinterpret_cast&lt;SkFont*&gt;(ptr);
    SkPaint* paint = reinterpret_cast&lt;SkPaint*&gt;(paintPtr);
    return instance-&gt;measureText(str, len * sizeof(KChar), SkTextEncoding::kUTF16, nullptr, paint);
}```
The problem: `measureText` expects a UTF-16 encoded string, but the input string is in UTF-8

Below Snippet is from `jvmMain/cpp/Font.cc` ,In this case, Text Measuring returns the correct width ( JVM Environment ), where the String's are processed as UTF-16.
```extern "C" JNIEXPORT jfloat JNICALL Java_org_jetbrains_skia_FontKt__1nMeasureTextWidth
  (JNIEnv* env, jclass jclass, jlong ptr, jstring str, jint len, jlong paintPtr) {
    SkFont* instance = reinterpret_cast&lt;SkFont*&gt;(static_cast&lt;uintptr_t&gt;(ptr));
    SkPaint* paint = reinterpret_cast&lt;SkPaint*&gt;(static_cast&lt;uintptr_t&gt;(paintPtr));
    const jchar* chars = env-&gt;GetStringCritical(str, nullptr);
    jfloat result = instance-&gt;measureText(chars, len * sizeof(jchar), SkTextEncoding::kUTF16, nullptr, paint);
    env-&gt;ReleaseStringCritical(str, chars);
    return result;
}```
*Workaround*:
Changing the encoding to UTF-8 in the `measureText` function gives the correct text width:
```SKIKO_EXPORT KFloat org_jetbrains_skia_Font__1nMeasureTextWidth
  (KNativePointer ptr, char* str, KInt len, KNativePointer paintPtr) {
    SkFont* instance = reinterpret_cast&lt;SkFont*&gt;(ptr);
    SkPaint* paint = reinterpret_cast&lt;SkPaint*&gt;(paintPtr);
    return instance-&gt;measureText(str, len, SkTextEncoding::kUTF8, nullptr, paint);
}```
*Question:*
 Is this workaround correct, or am I addressing the issue incorrectly? If there’s a better way to ensure proper font measurement, I’d appreciate any guidance.
Thanks in advance for your help!

I believe your workaround is rather correct.
Initially there were only the bindings for java. Then when the bindings were added for k/native and k/web, some code was migrated from the existing bindings. And probably it's a mistake of the copy/paste.

I see you've already reported this problem <https://youtrack.jetbrains.com/issue/SKIKO-995/Skiko-Text-Measurement-Encoding-Issue-Font.measureTextWidth>

Thank you :slightly_smiling_face:

Do you use these methods directly?
I believe we missed the problem, because in Compose it's using Paragraph, which can return lineMetrics.

Yes, I'm using `Font.measureTextWidth()` directly in my code. I also tried using `ParagraphBuilder,` add text and retrieve the bounds, and it does return the correct text width. However, I needed a more straightforward approach, which is why I relied on `Font.measureTextWidth()`.
Thanks again :grinning:

Hi <@UDV7KQT43>
Any update :slightly_smiling_face:

Thanks in advance.

Hey! No updates yet. Would you like to create a pull request + the tests?