Good morning! The markdown for the functions table...
# http4k
e
Good morning! The markdown for the functions table isn't rendering correctly on this page https://www.http4k.org/api/org.http4k.filter/-server-filters/#functions
Also it would be great if the page titles were better for the API pages - google search results are often not easy to parse with them all having the title "api | holds the markdown for the http4k API"
image.png
Or not publish the second?
s
All those issues are related to Dokka, which has proven to be a pain to configure properly.
Or not publish the second?
If you have suggestions on how to do so, we're happy to make the change or merge a PR ๐Ÿ™‚
๐Ÿ‘ 1
e
Thanks. Will raise a PR if I can see any way to make an improvement!
๐Ÿ™ 1
s
e
Looking in https://github.com/http4k/api/tree/master I see there is rendered HTML with recent commit dates and markdown that hasn't changed for 5 years
Is the "bad" content is coming from the old markdown? - It looks that way - i.e. the content on https://www.http4k.org/api/org.http4k.filter/-server-filters/ is out of date vs https://www.http4k.org/api/http4k-core/org.http4k.filter/-server-filters/index.html
I'm wondering if the fix is expunging the old markdown from the API repository - that could be an easy fix!
Hey @s4nchez, I think that is the fix - remove the .md files from the api repo that are being built by Jekyll in the "pages build and deployment" github action. https://github.com/http4k/api/actions/runs/12843869886/job/35816293011
and then possibly remove the "Build with Jekyll" step as that seems unneeded when the other pages are already rendered by dokka
I can't see the workflow definition for "pages build and deployment" though?
s
I'm not sure there's a specific worflow for the APIs. We just push content to the repo and GH Pages publishes it under
/api
.
Hmm I think deployments are not visible for people outside the http4k org
e
I can see those deployments
If you click on
view logs
for the last deployment, you can see it's doing the md -> html rendering in the build step https://github.com/http4k/api/actions/runs/12843869886/job/35816293011
s
So you reckon we should just remove all .md files from that repo?
e
I think so.
I guess the jekyll build step is harmless - it will just have nothing to process
s
I'm giving it a try
๐Ÿ‘ 1
The invalid pages are gone. Unfortunately, it'll take a while for Google to catch-up on those changes
e
Awesome!
I think this will be win long term
๐Ÿ’ฏ 1
People I work with always seem to end up on those old pages ๐Ÿ˜„
s
Absolutely. Thank you for reporting and looking into it. I wouldn't chase it otherwise ๐Ÿ˜‰
e
No problem