I'm half tempted to make a copy of it just to give...

# compose

[andrew]

I'm half tempted to make a copy of it just to give it scroll state

[Skaldebane]

You can wrap the inner text field in a Box with Modifier.horizontalScroll, and then expose that scroll state.

[andrew]

Then you have two scrollables to deal with... It's better this gets fixed at a platform level

[Skaldebane]

I do this on regular text fields for other reasons (content padding), and it leaves me a tiny tweeny bit worried about any potential performance hits (scroll containers can inhibit any internal lazy rendering the text field may be doing, as they force rendering everything), but it seems to be fine overall, I got apps in production with it.

Passwords are tiny, often single-line, so it's not an issue there at all.

[andrew]

especially because the implementation is shared between both BasicTextField and SecureBasicTextField

[andrew]

If it's the only way for now, I'll opt to do that

[andrew]

But, otherwise, if it exists in the platform, and just needs to be exposed, that's the better long term solution

[Skaldebane]

@andrew The horizontalScroll (or any other scroll container) will give the text infinite max width, so the inner scrolling of the text field will be basically non-existent, so it'll all feel as though there's one scroll container which is yours.

[Skaldebane]

but yeah, i agree, that's definitely an overlook by the Compose team
The two APIs should be largely identical unless it's really needed.

[andrew]

I realize that, yes. I'm just thinking because I already use the scrollstate of the inner text field from basic text field

[andrew]

Short term, I'll probably do this even if it's a little hacky 😂

[andrew]

1000014301.mp4

1000014301.mp4

[Skaldebane]

I'm in the same camp now because of lack of contentPadding, I have to do this hack :p

[andrew]

The edge treatment looks much better than the harsh clipping

[andrew]

This was my solution to compensate for that haha

[andrew]

The lack of contentPadding

[Skaldebane]

yeeep, that's exactly why I use it, I hate the clipping 😆

[andrew]

I'll just have to make sure I deal with orientation appropriately and live with it for now, until it's triaged and fixed

[Skaldebane]

I actually have it full-screen, so a fade could work, but the optimal thing is to have the text scroll under the navigation and status bars (like lazy lists)

[andrew]

That's fair

[andrew]

Because I'm so detail oriented, I often think of things the designers don't, purely because I have a knack for design and development, so the little extra things like this I will stress over

[andrew]

Definitely will have to think about how to handle multiline, effectively

[Skaldebane]

Shouldn't be too hard, you'll have to switch to verticalScroll though

[andrew]

It'll think it's constrained to infinity

[Skaldebane]

I'm not familiar with use-cases for multiline secure text fields (PGP keys maybe?), but it should be doable

[andrew]

I just have to be mindful of where it's being passed into which modifier (whether the BasicTextField is handling it or not)

[andrew]

I got it working, it's just less than ideal, but it works

[andrew]

Although it broke a few other things. I'll have to keep tinkering

[Skaldebane]

I have it working with a multiline text field (for content padding), works pretty well overall

[Skaldebane]

you may have issues with the cursor going out of view though

[andrew]

In my case I need to wrap the box containing the content + modifier in another box

[andrew]

For the faded edge treatment

[Skaldebane]

ahh i see
since it's BasicSecureTextField (the basic variant), I think you can apply that from the outside?
like, without using the decorator

[andrew]

I'm keeping it within the decorator since it handles the layout of other things

[andrew]

I also need to turn off the elastic overscroll as well

[Skaldebane]

oh wait you don't actually have to do that

[Skaldebane]

You could extract this whole thing into its own Composable (like a fork of the original) that also exposes scrollState
Then for the decorator, you just call the passed-in decorator parameter inside your decorator (confusing sentence :p)
and do all the scroll handling in there
this way you won't have to change anything about how you use it

[andrew]

It'd probably be easier to understand what's happening here if you had the code in front of you lol

[Skaldebane]

I can actually send some code, but it's tailored for vertical scroll
I'll make it handle horizontal and send it over

[andrew]

I have vertical scroll working fine

[andrew]

I just got a clean up horizontal

[andrew]

Since it stretches with the default overscroll effect

[andrew]

Okie dokie, it's fixed now

[andrew]

Screenshot_20250204-210948.png

[andrew]

screen-20250204-211034.mp4

screen-20250204-211034.mp4