Hey, we are in the migration phase from OpenTeleme...
# http4k
d
Hey, we are in the migration phase from OpenTelemetry 1.x to 2.x (I know we’re slow 🥱 ) Is someone already actively working on https://github.com/http4k/http4k/issues/943 or does it make sense to have a look at this? Not promising anything 🤗
s
Hi @DanielZ we haven't done that yet, so feel free to take a look. @dave and I agreed to not make that part of v6 release, but we're interested in adopting the OTel conventions (perhaps just referencing their constants, even).
👍 1
d
Hey @s4nchez, I’m wondering which approach is the most promising and fitting to http4k? I’m experimenting using
HttpAttributes
from OpenTelemetry in the
MetricsDefaults
. Some of that
*Attributes
are requiring for example a long instead of a string. which is conflicting using
HttpTransaction
. Now I’m wondering whether I should introduce something like a
MetricsLabeler
which takes an
HttpTransaction
and transforms it to an
OtelMetric
(which itself is a
Map<Attributes, Any>
). That would replace the
HttpTransactionLabeler
in the
OpenTelemetryMetrics
. Any suggestions on that?
s
Hey @DanielZ! Sorry for missing this message. We're ok changing
MetricsDefault
to use OpenTelemetry as the standard (I'd keep a copy as a
LegacyMetricsDefault
in case people still need it). Re: map type, I suggest changing
HttpTransaction#labels
to
<String, Any>
so it can hold longs. Would that do the trick?
Those are all breaking changes, but we're ok releasing a major version for them.
d
Hey, sorry for late response, was sick the last days. Nice, then I will continue working on that and create a PR in the next days 🎉
d
👍