```coroutineScope { launch { while (isActive) {...

# coroutines

[ursus]

coroutineScope {
	launch {
		while (isActive) { <--------
            
        }
	}
	...
}

coroutineScope {
	launch {
		while (true) { <---------
            
        }
	}
	...
}

When I want to do something while the coroutine is not cancelled - should I use isActive or true ? Both seem to work

[Youssef Shoaib [MOD]]

Depends on the code you have inside. isActive is probably safer.

[ursus]

Why?

say im sending some stuff to a channel

[streetsofboston]

If the code in your while-loop never calls any suspend functions, then while(true) will never end

[ursus]

I see. So, do you use it? I often don't see it even in first party samples. Somehow it seems like a unnecessary foot gun

[Joffrey]

You most often don't need an explicit isActive check because you usually call suspend functions inside the loop. If you don't, the correct fix is probably to add some yield() calls (or otherwise introduce suspension) rather than to change the condition

[kevin.cianfarini]

If the call inside the while loop blocks the calling thread then you'll need to introduce another mechanism to cooperatively cancel.

[ursus]

so...while(isActive) is the better practise it seems

[Joffrey]

No, not blocking is the better practice

[Joffrey]

@kevin.cianfarini yes, and usually also to suspend, like yield(). So you don't need isActive checks

[streetsofboston]

Or ensureActive() to be more expressive
https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines/ensure-active.html