what do people here think about the new Ignore API...

# failgood

[christophsturm]

what do people here think about the new Ignore API? https://github.com/failgood/failgood/pull/139

[Mervyn McCreight]

Nice effort!

I'm not sure what my opinion about the until functionality is, because this makes running the tests non-deterministic/stateful. A build can change from a good to a failing state without touching code 🤔. Do you have a special use-case for this functionality in mind? :-)

[christophsturm]

I have the feeling that some ignored tests should be revisited at some point. like “ignore this for now but remind me in 2 months”. its an experiment.

[christophsturm]

btw I just updated the PR. also I’m now thinking that disable is a better word than ignore. (disabling something is an active act, and results in a test being ignored or skipped) wdyt about that?

[christophsturm]

also another way to disable a test could be to just call skip or ignore inside the test, possibly as first command. that would then throw a SkipException and report the test as skipped. I think I like that option even better. (and interestingly in that context disable would not make much sense). that has the downside that a test where you just add skip at the end would still count as skipped even if it does test things. but maybe thats a good thing, maybe you could mark unfinished tests that way.

[christophsturm]

another thing is that disable or ignore should have a reason. something like ignore=Ignore.Because("this test sucks")